Re: Review Request 108776: apidoc: Make inherited sections collapsable and expandable

2013-02-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108776/#review26665 --- This review has been submitted with commit

Re: kwalletmanager ui refactor

2013-02-05 Thread Aurélien Gâteau
Le Monday 04 February 2013 23:50:49 Valentin Rusu a écrit : On Monday 04 February 2013 19:28:42 Aurélien Gâteau wrote: Le Sunday 03 February 2013 14:50:33 Valentin Rusu a écrit : A screen capture is far better than a hundred words so here it is: http://imgur.com/MD3GDxO Hey,

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108770/#review26689 --- I don't like this. It's a coverup for a bug that would still

Re: KDE Review: Kor - a minimalistic desktop shell

2013-02-05 Thread Thomas Lübking
On Dienstag, 5. Februar 2013 20:06:53 CEST, Albert Astals Cid wrote: Kor Testudo Shell does Testudo mean something? Latin / tortoise ie. a turtle and also the mlitary tactic.

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-05 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108770/ --- (Updated Feb. 5, 2013, 1:31 p.m.) Review request for kdelibs.

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-05 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108770/ --- (Updated Feb. 5, 2013, 3:39 p.m.) Review request for kdelibs. Changes

Re: Review Request 108727: ktimezoned: Watch /etc/localtime if it doesn't exist yet.

2013-02-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108727/#review26711 --- Looks ok to me, although I don't really know this code. -

Re: KDE Review: Kor - a minimalistic desktop shell

2013-02-05 Thread Lubos Lunak
On Tuesday 05 of February 2013, Tomaz Canabrava wrote: 'Big Forehead' in portuguese. ROTFL. I should make up an odd story based on this (BTW, 'cor' also apparently means 'odd' in Irish). So, as you might have noticed, it has almost become a tradition that SUSE people use odd names whenever

Re: Review Request 108637: Fix KColorButton change color + cancel behaviour

2013-02-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108637/ --- (Updated Feb. 5, 2013, 11:53 p.m.) Review request for kdelibs and Laurent

Re: Review Request 108637: Fix KColorButton change color + cancel behaviour

2013-02-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108637/ --- (Updated Feb. 5, 2013, 11:56 p.m.) Review request for kdelibs and Laurent

Re: Review Request 108637: Fix KColorButton change color + cancel behaviour

2013-02-05 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108637/#review26728 --- Ship it! For me seems good. Ship it. - Laurent Montel On