Re: Review Request 108727: ktimezoned: Watch /etc/localtime if it doesn't exist yet.

2013-02-21 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108727/#review27845 --- Ship it! I'm sorry this has taken so long - I've been incredib

Re: [kdelibs] kio/kfile: completeBaseName gives us "foo.bar" for "foo.bar.png"

2013-02-21 Thread Aaron J. Seigo
Hi .. I pushed this set of changes into master by accident, after having done the development in a local branch. Wasn't thinking .. it's also in KDE/4.10 branch at this point as well. (Well, I was thinking -> "I will have to pull this into the stable branch and then into master .. ah, right, k

Re: Review Request 109049: Fix favicon support for chrome bookmarks on krunner

2013-02-21 Thread Marco Gulino
> On Feb. 20, 2013, 1:06 a.m., Àlex Fiestas wrote: > > I guess this will break compatibility with old versions then? if so, do you > > know from which version will it work? > > If this was not long ago, can we check the version and keep supporting the > > old and the new one? > > Àlex Fiestas

Re: Review Request 109049: Fix favicon support for chrome bookmarks on krunner

2013-02-21 Thread Marco Gulino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109049/ --- (Updated Feb. 21, 2013, 7:29 p.m.) Review request for kde-workspace and Pl

Re: Review Request 109049: Fix favicon support for chrome bookmarks on krunner

2013-02-21 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109049/#review27876 --- Ship it! Tested the patch with chromiium 24.0.1312.70 (181759

Re: Review Request 109049: Fix favicon support for chrome bookmarks on krunner

2013-02-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109049/#review27881 --- This review has been submitted with commit 9fb3c1daa5879f30c29

Re: Review Request 109049: Fix favicon support for chrome bookmarks on krunner

2013-02-21 Thread Marco Gulino
> On Feb. 22, 2013, 12:41 a.m., Àlex Fiestas wrote: > > Tested the patch with chromiium 24.0.1312.70 (181759) worked fine. > > > > Code wise it looks fine as well. Thanks! Applied to branches KDE/4.10, and master, I guess it's enough. - Marco ---