Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

2013-04-26 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/ --- (Updated April 26, 2013, 7:37 a.m.) Review request for kdelibs and KDEPIM-

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

2013-04-26 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/#review31608 --- I am wondering if it wouldnt't make more sense to have the PIM

Re: Review Request 106581: Make KFileDialog remember settings

2013-04-26 Thread Boudewijn Rempt
> On April 10, 2013, 10:52 p.m., Albert Astals Cid wrote: > > Aurelien: David: apaku: Ping? > > Aurélien Gâteau wrote: > Still in my TODO list :/ Looks there _is_ user demand: 16:17:17 < RaktenUser> while I am compiling Why are the mounts resolved to places in the file requester? We h

libs/kworkspace/kdisplaymanager.cpp mess

2013-04-26 Thread Martin Briza
Hi everyone, after fixing a bit in the $subj file I've realized it (in my opinion) should be split into one abstract class with a factory handling the back-ends provided by the current session managers such as ConsoleKit and systemd-logind while providing one module for the legacy DMs with

Re: libs/kworkspace/kdisplaymanager.cpp mess

2013-04-26 Thread Albert Astals Cid
El Dijous, 25 d'abril de 2013, a les 15:11:25, Martin Briza va escriure: > Hi everyone, > > after fixing a bit in the $subj Which repo is that? Are we installing that file header? Cheers, Albert > file I've realized it (in my opinion) > should be split into one abstract class with a factory

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

2013-04-26 Thread Ömer Fadıl Usta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/ --- (Updated April 27, 2013, 7:16 a.m.) Review request for kdelibs, Aaron J. S