Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

2013-05-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/#review31830 --- This review has been submitted with commit ebca90e1a50435f27cb

Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

2013-05-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110138/ --- (Updated May 1, 2013, 10:53 a.m.) Status -- This change has been mark

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-01 Thread Róbert Szókovács
> On April 16, 2013, 5:15 p.m., Christoph Feck wrote: > > Nice idea, would be better to use Unicode Private Use Areas instead of > > 0x18000 codes. I've been considering that, too. I don't think it's very likely that someone will legitimely use neither the PUA or any currently unassigned area

Re: Review Request 110091: clean up and update FreeBSD support for kinfocenter

2013-05-01 Thread Rolf Eike Beer
> > On April 20, 2013, 2:11 p.m., Rolf Eike Beer wrote: > > > kinfocenter/Modules/base/info_fbsd.cpp, line 136 > > > > > ine136>> > > > > Why not just use QProcess here to get the result? I fear this stuff > > > dat

Plasma Workspaces 4.11: the last feature release in the 4.x series for kde-workspace

2013-05-01 Thread Aaron J. Seigo
Hello everyone, tl;dr -> 4.11 will be the last feature release of kde-workspace. Plasma Workspaces will be feature frozen and we are committing to 2 years of maintenance releases of 4.11. The next feature release of kde-workspace will be Plasma Workspaces 2, based on Qt5. This does not impact

Re: Plasma Workspaces 4.11: the last feature release in the 4.x series for kde-workspace

2013-05-01 Thread Andriy Rysin
If the feature freeze for 4.11 is May 22 and there is no more feature releases for branch 4.x, where all those features from GSoC go? I don't think students should work on version 5 yet... On May 1, 2013 9:16 AM, "Aaron J. Seigo" wrote: > ** > > Hello everyone, > > > > tl;dr -> 4.11 will be the l

Re: Plasma Workspaces 4.11: the last feature release in the 4.x series for kde-workspace

2013-05-01 Thread Aaron J. Seigo
On Wednesday, May 1, 2013 15:15:45 Aaron J. Seigo wrote: > For Plasma Workspaces 2, our goal is to have a user ready release in Q2 > 2013. 2014, obviously. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part.

Re: Review Request 110118: wrong path for plugin. ( doubling the plugin address cause the basepath to "" )

2013-05-01 Thread Ömer Fadıl Usta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110118/#review31837 --- ping ? - Ömer Fadıl Usta On April 21, 2013, 9:18 p.m., Ömer

Review Request 110259: Fix kurifiltertest to use the new google query

2013-05-01 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110259/ --- Review request for KDE Runtime. Description --- My previous review (h

Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

2013-05-01 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110262/ --- Review request for kdelibs. Description --- The current algorithm tha

Re: Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

2013-05-01 Thread Parker Coates
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110262/#review31856 --- Since KRandomSequence is a class for generating a predictable r

Re: Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

2013-05-01 Thread Parker Coates
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110262/#review31854 --- Since KRandomSequence is a class for generating a predictable r

Re: Review Request 110262: KRandomSequence::randomize: use the Fisher-Yates Algorithm to achieve O(N) complexity

2013-05-01 Thread Parker Coates
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110262/#review31855 --- Since KRandomSequence is a class for generating a predictable r