Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-10 Thread Kai Uwe Broulik
On May 7, 2013, 12:50 p.m., Dominik Haumann wrote: The patch itself is fine and most likely does not introduce regressions in terms of misbehavior. Still, is never showing an icon the way to go? Another way to work around this by default would be an additional function called

kde review kartesio

2013-05-10 Thread LucaTringali
Hello,I have been working on Kartesio, a program for calculating best fit curves with experimental points. I think it is ready to be moved in the KDE Edu main repo now, so I'm asking your approval.I followed the guidelines (http://techbase.kde.org/Policies/Application_Lifecycle) and Kartesio is

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-10 Thread Thomas Lübking
On May 7, 2013, 12:50 p.m., Dominik Haumann wrote: The patch itself is fine and most likely does not introduce regressions in terms of misbehavior. Still, is never showing an icon the way to go? Another way to work around this by default would be an additional function called

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-10 Thread Eli MacKenzie
On May 7, 2013, 8:50 a.m., Dominik Haumann wrote: The patch itself is fine and most likely does not introduce regressions in terms of misbehavior. Still, is never showing an icon the way to go? Another way to work around this by default would be an additional function called

Re: kde review kartesio

2013-05-10 Thread Anne-Marie Mahfouf
Hi, I am wondering what is the user base for this application as it seems quite specialized (I did not build it yet though). Can you tell us more about the potential target? Another question that comes to mind is: can't it be a feature of an existing KDE Edu apps? Best regards, Anne-Marie

Re: kde review kartesio

2013-05-10 Thread Tomaz Canabrava
Quite Unlikely ... It's a Solver, to fit curves into points, That's very used in any theorical research, engeniering, math, phisics, etc. 2013/5/10 Anne-Marie Mahfouf annemarie.mahf...@free.fr Hi, I am wondering what is the user base for this application as it seems quite specialized

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

2013-05-10 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/ --- (Updated May 10, 2013, 10:32 a.m.) Review request for kdelibs and

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

2013-05-10 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/#review32310 --- Ship it! Ship It! - Kevin Krammer On May 10, 2013, 10:32

Re: kde review kartesio

2013-05-10 Thread Anne-Marie Mahfouf
Hi, A few primary remarks: - libzorbaneural is needed but my distro does not have anything with neural in it (OpenSuse 12.3) what repo do I need to add in order to get it? The libzorbaneural website should be added to the cmake file so people can find this and packagers can add it to their

Re: kde review kartesio

2013-05-10 Thread David Edmundson
The app sounds awesome. From the application life cycle page you linked: When you have made one of more releases and want to continue to develop it, the term 'playground' does no longer apply to you. That is the right time to move out of here There are no releases on download.kde.org under

Re: kde review kartesio

2013-05-10 Thread Tomaz Canabrava
Annma, I find that proposal *very* good. I'm a bit distant of KDE programming - I know - because my day job is making me work 12h+ creating scientific tools. ( actually - one of the tools that I created here was a... Solver, to fit curves on points... ) Tomaz 2013/5/10 David Edmundson

Re: kde review kartesio

2013-05-10 Thread Sven Brauch
Hey! A good thing, I think such a tool could be useful to me too (and I know a lot of other people to whom it might be useful). Here's what I noticed from a quick look (some has been said already I think): * You probably shouldn't track the kdev4 file in the repository, same goes for screenshots

Re: Re: Re: kde review kartesio

2013-05-10 Thread David Edmundson
On Fri, May 10, 2013 at 3:38 PM, LucaTringali tringalinv...@libero.it wrote: The fact is that, before releasing the first binary package, I would like to be sure the code respects KDE guidelines. Otherwise, I would need to create a second package just to adjust the code for KDE. Luca

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

2013-05-10 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/#review32318 --- CMakeLists.txt

Re: Re: kde review kartesio

2013-05-10 Thread Sven Brauch
Hi Luca, Yes, the correct way to express a power is ^. So you should write x^2. I figured that after it had crashed ;) There should be a check routine to avoid that a dangerous string like ** is used, and I'm surely integrating this check in the next release. In my opinion you should not

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-10 Thread Róbert Szókovács
On May 7, 2013, 10:11 a.m., Róbert Szókovács wrote: The solution is intentionally shy, I really don't want to fan the flames surrounding this issue. I just stumbled upon this location when it can be handled painlessly. Whether or not it should be turned on by default, in my opinion,

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-10 Thread Thomas Lübking
On May 7, 2013, 10:11 a.m., Róbert Szókovács wrote: The solution is intentionally shy, I really don't want to fan the flames surrounding this issue. I just stumbled upon this location when it can be handled painlessly. Whether or not it should be turned on by default, in my opinion,

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-10 Thread Dominik Haumann
On May 7, 2013, 12:50 p.m., Dominik Haumann wrote: The patch itself is fine and most likely does not introduce regressions in terms of misbehavior. Still, is never showing an icon the way to go? Another way to work around this by default would be an additional function called