Review Request 110459: Klipper: Allow to keep items in clipboard history

2013-05-15 Thread José Millán Soto
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110459/ --- Review request for kde-workspace. Description --- This patch allows u

Re: Review Request 108442: [High-dpi issues] Fix KIconButton initial icon size and its occurence in KPropertiesDialog

2013-05-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108442/ --- (Updated May 15, 2013, 7:37 p.m.) Review request for kdelibs. Changes --

Re: Review Request 110084: Make ftp error messages prettier

2013-05-15 Thread Kai Uwe Broulik
> On April 19, 2013, 1:13 p.m., David Faure wrote: > > Well, yes, it looks nicer to my eyes because I'm not very good at german > > (and your "before" screenshot is in german) :-P > > > > More seriously I'm not sure this will always work... what if the error > > message is much longer? Shouldn

Re: KF5 Update Meeting 2013-w20

2013-05-15 Thread Alexander Neundorf
On Wednesday 15 May 2013, Kevin Ottens wrote: > Hello all, > > So yesterday 4pm (Paris timezone :p) as planned we had the first update is it planned to have those meetings sometimes also later in the day ? At 4pm I'm at work, and so can't attend. ... > Action items: > * [ervin] Send meeting rem

Re: Review Request 110084: Make ftp error messages prettier

2013-05-15 Thread Thomas Lübking
> On April 19, 2013, 1:13 p.m., David Faure wrote: > > Well, yes, it looks nicer to my eyes because I'm not very good at german > > (and your "before" screenshot is in german) :-P > > > > More seriously I'm not sure this will always work... what if the error > > message is much longer? Shouldn

Re: Review Request 110084: Make ftp error messages prettier

2013-05-15 Thread Kai Uwe Broulik
> On April 19, 2013, 1:13 p.m., David Faure wrote: > > Well, yes, it looks nicer to my eyes because I'm not very good at german > > (and your "before" screenshot is in german) :-P > > > > More seriously I'm not sure this will always work... what if the error > > message is much longer? Shouldn

Re: Review Request 110430: [Taskbar applet] Added actions to be perfomed on middle click

2013-05-15 Thread Albert Vaca Cintora
> On May 15, 2013, 6:06 a.m., Aaron J. Seigo wrote: > > I am not in favour of this patch for a couple of reasons. First, there is a > > port underway to QML which does not need to be delayed further by adding > > more features. More importantly, however, "middle click" is a special case > > of

Re: Review Request 110430: [Taskbar applet] Added actions to be perfomed on middle click

2013-05-15 Thread Martin Gräßlin
> On May 15, 2013, 8:06 a.m., Aaron J. Seigo wrote: > > I am not in favour of this patch for a couple of reasons. First, there is a > > port underway to QML which does not need to be delayed further by adding > > more features. More importantly, however, "middle click" is a special case > > of

Re: Review Request 110430: [Taskbar applet] Added actions to be perfomed on middle click

2013-05-15 Thread Aaron J. Seigo
> On May 15, 2013, 6:06 a.m., Aaron J. Seigo wrote: > > I am not in favour of this patch for a couple of reasons. First, there is a > > port underway to QML which does not need to be delayed further by adding > > more features. More importantly, however, "middle click" is a special case > > of

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110327/ --- (Updated May 15, 2013, 1:54 p.m.) Status -- This change has been mark

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110327/#review32564 --- This review has been submitted with commit c8264896312e244e028

Re: Review Request 110430: [Taskbar applet] Added actions to be perfomed on middle click

2013-05-15 Thread Albert Vaca Cintora
> On May 15, 2013, 6:06 a.m., Aaron J. Seigo wrote: > > I am not in favour of this patch for a couple of reasons. First, there is a > > port underway to QML which does not need to be delayed further by adding > > more features. More importantly, however, "middle click" is a special case > > of

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-15 Thread Róbert Szókovács
> On May 7, 2013, 10:11 a.m., Róbert Szókovács wrote: > > The solution is intentionally "shy", I really don't want to fan the flames > > surrounding this issue. I just stumbled upon this location when it can be > > handled painlessly. Whether or not it should be turned on by default, in my > >

Re: Review Request 110327: KMessageWidget: Remove decoration icon

2013-05-15 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110327/ --- (Updated May 15, 2013, 11:45 a.m.) Review request for Dolphin, Kate and kd