Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-24 Thread Martin Gräßlin
> On May 24, 2013, 11:44 p.m., Jekyll Wu wrote: > > Bugzilla itself (since 4.2.5) already rejects any attempt against disabled > > versions. So even without this patch, DrKonqi users won't be able to create > > crash report against disabled versions in the end. From developers POV, you > > don

Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-24 Thread Martin Gräßlin
> On May 24, 2013, 11:44 p.m., Jekyll Wu wrote: > > Bugzilla itself (since 4.2.5) already rejects any attempt against disabled > > versions. So even without this patch, DrKonqi users won't be able to create > > crash report against disabled versions in the end. From developers POV, you > > don

Re: Moving Plasma Media Center to extragear

2013-05-24 Thread David Edmundson
>From my side (as someone who reviewed this) I'm happy for this to go to extragear too. David On Tue, May 21, 2013 at 5:37 AM, Sinny Kumari wrote: > Hi, > > Any news on this? Does PMC look ok now from your side so that we can move it > to extragear ? > > If not, please let us know what all chang

Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-24 Thread Jekyll Wu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110633/#review33110 --- Bugzilla itself (since 4.2.5) already rejects any attempt again

Re: Moving Plasma Media Center to extragear

2013-05-24 Thread Burkhard Lück
Am Mittwoch, 22. Mai 2013, 08:11:49 schrieb Burkhard Lück: > Am Dienstag, 21. Mai 2013, 10:07:50 schrieb Sinny Kumari: > > Hi, > > > > Any news on this? Does PMC look ok now from your side so that we can move > > it to extragear ? > > > > If not, please let us know what all changes we still need

Re: Moving Plasma Media Center to extragear

2013-05-24 Thread Sinny Kumari
On Wed, May 22, 2013 at 11:41 AM, Burkhard Lück wrote: > Am Dienstag, 21. Mai 2013, 10:07:50 schrieb Sinny Kumari: > > Hi, > > > > Any news on this? Does PMC look ok now from your side so that we can move > > it to extragear ? > > > > If not, please let us know what all changes we still need to d

Re: Review Request 109246: Make KUrl::relativePath and KUrl::relativeUrl work correctly on Windows

2013-05-24 Thread Albert Astals Cid
> On May 23, 2013, 9:16 a.m., Patrick von Reth wrote: > > Sorry for the missing feedback we already apply your patch locally and its > > already part of our release so please ship it. > > > > BIG THANKS > > Michel Ludwig wrote: > Ok. As I haven't done any commits to kdelibs in a while, doe

Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110633/ --- Review request for KDE Runtime, Plasma, Ben Cooksley, and Myriam Schweingrub

Re: Review Request 109246: Make KUrl::relativePath and KUrl::relativeUrl work correctly on Windows

2013-05-24 Thread Michel Ludwig
> On May 23, 2013, 9:16 a.m., Patrick von Reth wrote: > > Sorry for the missing feedback we already apply your patch locally and its > > already part of our release so please ship it. > > > > BIG THANKS > > Michel Ludwig wrote: > Ok. As I haven't done any commits to kdelibs in a while, doe

Re: Review Request 109246: Make KUrl::relativePath and KUrl::relativeUrl work correctly on Windows

2013-05-24 Thread Aleix Pol Gonzalez
> On May 23, 2013, 9:16 a.m., Patrick von Reth wrote: > > Sorry for the missing feedback we already apply your patch locally and its > > already part of our release so please ship it. > > > > BIG THANKS > > Michel Ludwig wrote: > Ok. As I haven't done any commits to kdelibs in a while, doe

Re: Review Request 106300: add kimgio WebP image format plugin

2013-05-24 Thread Albert Astals Cid
El Dijous, 23 de maig de 2013, a les 09:47:36, Martin Koller va escriure: > On Wednesday 22 May 2013 22:15:56 Albert Astals Cid wrote: > > > On May 18, 2013, 12:44 p.m., Commit Hook wrote: > > > > This review has been submitted with commit > > > > df845b06bc440fff5a43a9cdc149e8c88c29bc67 by Martin

Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

2013-05-24 Thread Thomas Lübking
> On May 3, 2013, 6:52 p.m., Marco Martin wrote: > > any news on this? > > Martin, what do you think about it? > > Ralf Jung wrote: > Thomas fixed some existing issues which were uncovered by this patch, see > https://bugs.kde.org/show_bug.cgi?id=179042#c71 . As far as I can tell, no > oth

Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

2013-05-24 Thread Aaron J. Seigo
> On May 3, 2013, 6:52 p.m., Marco Martin wrote: > > any news on this? > > Martin, what do you think about it? > > Ralf Jung wrote: > Thomas fixed some existing issues which were uncovered by this patch, see > https://bugs.kde.org/show_bug.cgi?id=179042#c71 . As far as I can tell, no > oth