Re: Review Request 110834: Cache the result of the KDE::stat calls in KDirListerCache::slotFileDirty

2013-06-07 Thread Dawit Alemayehu
> On June 7, 2013, 12:32 p.m., David Faure wrote: > > kio/kio/kdirlister.cpp, line 648 > > > > > > This seems potentially very slow to me. > > When navigating away from a dir and there's a large tree view with

Review Request 110875: kcm_useraccount: support accountsservice

2013-06-07 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110875/ --- Review request for KDE Base Apps. Description --- save image file wit

K(Abstract)FileItemActionPlugin

2013-06-07 Thread Frank Reininghaus
Hi everyone, I've recently implemented a mechanism that allows developers of KAbstractFileItemActionPlugins to state that their plugin should not be shown in file-management related context menus by default [1]. I've been thinking again about this approach again this week, and now I think that it

Review Request 110865: KConfig: fix long-standing bug where translations would not be loaded.

2013-06-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110865/ --- Review request for kdelibs and Oswald Buddenhagen. Description --- KC

Re: Review Request 110865: KConfig: fix long-standing bug where translations would not be loaded.

2013-06-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110865/ --- (Updated June 7, 2013, 1:28 p.m.) Review request for kdelibs and Oswald Bu

Re: Review Request 110865: KConfig: fix long-standing bug where translations would not be loaded.

2013-06-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110865/ --- (Updated June 7, 2013, 1:24 p.m.) Review request for kdelibs and Oswald Bu

Re: Review Request 103168: KConfig: properly implement revertToDefault().

2013-06-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103168/ --- (Updated June 7, 2013, 1:20 p.m.) Review request for kdelibs, Thomas Braxt

Re: Review Request 103168: KConfig: properly implement revertToDefault().

2013-06-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103168/ --- (Updated June 7, 2013, 1:19 p.m.) Review request for kdelibs, Thomas Braxt

Re: Review Request 110834: Cache the result of the KDE::stat calls in KDirListerCache::slotFileDirty

2013-06-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110834/#review33899 --- kio/kio/kdirlister.cpp