Re: Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

2013-06-09 Thread Simeon Bird
> On June 9, 2013, 10:27 a.m., Albert Astals Cid wrote: > > Being past the Feature Freeze doesn't seem a good idea to me to remove a > > feature. > > Simeon Bird wrote: > It isn't really removing a feature - the code in question does nothing at > all that I can see, and hasn't done for a w

Re: Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

2013-06-09 Thread Simeon Bird
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110898/ --- (Updated June 10, 2013, 1:09 a.m.) Status -- This change has been dis

Review Request 110924: Fix Bug 320335 - Problem with tree view when using programs:/ protocol

2013-06-09 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110924/ --- Review request for KDE Runtime and David Faure. Description --- Creat

Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

2013-06-09 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110922/ --- Review request for Dolphin, KDE Base Apps, David Faure, and Frank Reininghau

Re: Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

2013-06-09 Thread Albert Astals Cid
> On June 9, 2013, 10:27 a.m., Albert Astals Cid wrote: > > Being past the Feature Freeze doesn't seem a good idea to me to remove a > > feature. > > Simeon Bird wrote: > It isn't really removing a feature - the code in question does nothing at > all that I can see, and hasn't done for a w

Re: Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

2013-06-09 Thread Vishesh Handa
> On June 9, 2013, 10:27 a.m., Albert Astals Cid wrote: > > Being past the Feature Freeze doesn't seem a good idea to me to remove a > > feature. > > Simeon Bird wrote: > It isn't really removing a feature - the code in question does nothing at > all that I can see, and hasn't done for a w

Re: Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

2013-06-09 Thread Michael Pyne
On Sun, June 9, 2013 16:11:27 Simeon Bird wrote: > > On June 9, 2013, 10:27 a.m., Albert Astals Cid wrote: > > > Being past the Feature Freeze doesn't seem a good idea to me to remove a > > > feature. > It isn't really removing a feature - the code in question does nothing at > all that I can see,

Re: Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

2013-06-09 Thread Hrvoje Senjan
> On June 9, 2013, 8:38 a.m., Christophe Giboudeaux wrote: > > plasma/desktop/applets/kickoff/core/config-kickoff-applets.h.cmake:#cmakedefine > > HAVE_STRIGIDBUS 1 > > > > this line is not needed anymore with this change > > Simeon Bird wrote: > Thanks - that file consists only of that li

Re: Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

2013-06-09 Thread Simeon Bird
> On June 9, 2013, 10:27 a.m., Albert Astals Cid wrote: > > Being past the Feature Freeze doesn't seem a good idea to me to remove a > > feature. It isn't really removing a feature - the code in question does nothing at all that I can see, and hasn't done for a while. In fact, I'm not sure the

Re: Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

2013-06-09 Thread Simeon Bird
> On June 9, 2013, 8:38 a.m., Christophe Giboudeaux wrote: > > plasma/desktop/applets/kickoff/core/config-kickoff-applets.h.cmake:#cmakedefine > > HAVE_STRIGIDBUS 1 > > > > this line is not needed anymore with this change Thanks - that file consists only of that line. Should I also remove the

Re: Review Request 110875: kcm_useraccount: support accountsservice

2013-06-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110875/#review33926 --- Ship it! Few minor comments. kdepasswd/kcm/main.cpp

Re: K(Abstract)FileItemActionPlugin

2013-06-09 Thread Albert Astals Cid
El Diumenge, 9 de juny de 2013, a les 09:22:10, Frank Reininghaus va escriure: > Hi Albert, > > thanks for your comments. > > 2013/6/8 Albert Astals Cid: > > El Divendres, 7 de juny de 2013, a les 17:40:29, Frank Reininghaus va > > > > escriure: > >> Hi everyone, > > > > Hi > > > >> I've recen

Re: Review Request 110367: Add JoinTheGame menu entry

2013-06-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110367/ --- (Updated June 9, 2013, 10:27 a.m.) Status -- This change has been dis

Re: Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

2013-06-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110898/#review33978 --- Being past the Feature Freeze doesn't seem a good idea to me to

Re: Review Request 110476: Call KNotification::close() when notification is closed in the applet

2013-06-09 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110476/#review33973 --- Anyone please? :-) - Dan Vrátil On May 16, 2013, 9:38 p.m.,

Re: Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

2013-06-09 Thread Christophe Giboudeaux
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110898/#review33969 --- plasma/desktop/applets/kickoff/core/config-kickoff-applets.h.cm

Re: K(Abstract)FileItemActionPlugin

2013-06-09 Thread Frank Reininghaus
Hi Albert, thanks for your comments. 2013/6/8 Albert Astals Cid: > El Divendres, 7 de juny de 2013, a les 17:40:29, Frank Reininghaus va > escriure: >> Hi everyone, > > Hi > >> I've recently implemented a mechanism that allows developers of >> KAbstractFileItemActionPlugins to state that their pl