Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111206: Fix the Delete/Move To Trash actions for remote files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111206/ --- (Updated June 25, 2013, 2:43 a.m.) Status -- This change has been mar

Re: Review Request 111206: Fix the Delete/Move To Trash actions for remote files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111206/#review35009 --- This review has been submitted with commit e688a52e3c84d7f1106

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111206: Fix the Delete/Move To Trash actions for remote files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111206/#review35004 --- Ship it! Ship It! - Frank Reininghaus On June 24, 2013, 12:

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 12:58 p.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

[KDM] Potential NULL pointer deref. w/. glibc 2.17+

Hello. Starting with glibc 2.17 (eglibc 2.17), crypt() fails with EINVAL (w/ NULL return) if the salt violates specifications. Additionally, on FIPS-140 enabled Linux systems, DES or MD5 encrypted passwords passed to crypt() fail with EPERM (w/ NULL return). If using glibc's crypt() or shadow's p

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 12:58 p.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111206: Fix the Delete/Move To Trash actions for remote files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111206/ --- (Updated June 24, 2013, 12:15 p.m.) Review request for KDE Base Apps, Davi

Re: Review Request 111206: Fix the Delete/Move To Trash actions for remote files

> On June 24, 2013, 8:38 a.m., Frank Reininghaus wrote: > > Thanks for the patch Dawit! The approach looks good to me, from my point of > > view this can go in unless David has any objections. One little question > > though: is there a reason why you moved the "Trash/Delete"-related code to >

Re: Review Request 111050: Fast mime detection speedup.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34953 --- The test you should be running is kmimetypetest, not kurlmimety

Re: Review Request 111158: Fix KLinkItemSelectionModel handling of QItemSelectionModel::Toggle flag

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/58/#review34950 --- This review has been submitted with commit c52375c97605d56579d

Re: Review Request 111158: Fix KLinkItemSelectionModel handling of QItemSelectionModel::Toggle flag

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/58/ --- (Updated June 24, 2013, 9:08 a.m.) Status -- This change has been mar

Re: Review Request 111206: Fix the Delete/Move To Trash actions for remote files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111206/#review34949 --- No objections. - David Faure On June 24, 2013, 5:58 a.m., Da

Re: Review Request 111206: Fix the Delete/Move To Trash actions for remote files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111206/#review34946 --- Thanks for the patch Dawit! The approach looks good to me, from

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default