Re: Review Request 111164: Create FavIconsModule namespace in kdebug

2013-08-15 Thread Albert Astals Cid
> On June 21, 2013, 8:29 p.m., David Faure wrote: > > It's all commented out, but if that makes you happy, go for it :) > > > > (yes, make the function file-static first) Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?

Re: Review Request 110090: Clean up kickoff from stale bits

2013-08-15 Thread Albert Astals Cid
> On May 8, 2013, 2:57 p.m., Raphael Kubo da Costa wrote: > > Thanks for the cleanup. You might also want to remove the references to > > Strigi in DESIGN-GOALS and STATUS-TODO, but I guess they're very outdated > > anyway. Please include a descriptive commit message explaining that this > > p

Re: Review Request 110042: Find Qt5 version of DBusMenuQt

2013-08-15 Thread Albert Astals Cid
> On May 20, 2013, 2:08 a.m., Ian Monroe wrote: > > Ship It! Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting? - Albert --- This is an automatically generated e-ma

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112099/#review37860 --- This review has been submitted with commit dc12eba0f02545f6213

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112099/ --- (Updated Aug. 15, 2013, 5:04 p.m.) Status -- This change has been mar

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Santeri Piippo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112099/ --- (Updated Aug. 15, 2013, 7:29 p.m.) Review request for KDE Runtime and Albe

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Santeri Piippo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112099/ --- (Updated Aug. 15, 2013, 7:29 p.m.) Review request for KDE Runtime and Albe

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Santeri Piippo
> On Aug. 15, 2013, 5:16 p.m., Albert Astals Cid wrote: > > Thanks for the patch! > > > > The enum thing seems a bit overkill to me, i mean, how "expensive" is the > > updateSample function after all? Personally, I'd just call it and that's > > it. Also makes sure you don't introduce subtle bu

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Santeri Piippo
> On Aug. 15, 2013, 5:16 p.m., Albert Astals Cid wrote: > > Thanks for the patch! > > > > The enum thing seems a bit overkill to me, i mean, how "expensive" is the > > updateSample function after all? Personally, I'd just call it and that's > > it. Also makes sure you don't introduce subtle bu

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Albert Astals Cid
> On Aug. 15, 2013, 2:16 p.m., Albert Astals Cid wrote: > > Thanks for the patch! > > > > The enum thing seems a bit overkill to me, i mean, how "expensive" is the > > updateSample function after all? Personally, I'd just call it and that's > > it. Also makes sure you don't introduce subtle bu

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Santeri Piippo
> On Aug. 15, 2013, 2:16 p.m., Albert Astals Cid wrote: > > Thanks for the patch! > > > > The enum thing seems a bit overkill to me, i mean, how "expensive" is the > > updateSample function after all? Personally, I'd just call it and that's > > it. Also makes sure you don't introduce subtle bu

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112099/#review37845 --- Thanks for the patch! The enum thing seems a bit overkill to m

Re: Review Request 112099: [kcontrol/locale] update the sample when input changed

2013-08-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112099/ --- (Updated Aug. 15, 2013, 2:07 p.m.) Review request for KDE Runtime and Albe

Re: Review Request 112081: Add reviewboard-am, a tool to apply patches from KDE reviewboard

2013-08-15 Thread David Edmundson
> On Aug. 15, 2013, 10:55 a.m., Heinz Wiesinger wrote: > > How does this compare to "rbt patch"? > > (http://www.reviewboard.org/docs/rbtools/0.5/rbt/commands/patch/) > > > > It sounds to me like it's meant to accomplish the same thing That applies a patch to some code. Aurelien's version als

Re: Review Request 112081: Add reviewboard-am, a tool to apply patches from KDE reviewboard

2013-08-15 Thread Heinz Wiesinger
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112081/#review37834 --- How does this compare to "rbt patch"? (http://www.reviewboard.

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-15 Thread Patrick Spendrin
> On Aug. 12, 2013, 10:53 p.m., Patrick Spendrin wrote: > > kioslave/thumbnail/CMakeLists.txt, line 160 > > > > > > this could be moved out of the parentheses right? > > Andrius da Costa Ribas wrote: > I didn