Review Request 112234: Save krunner dialog size when manually resized

2013-08-24 Thread Harald Hvaal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112234/ --- Review request for kde-workspace. Description --- This size was

Review Request 112235: Move focus to search field upon typing from result list

2013-08-24 Thread Harald Hvaal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112235/ --- Review request for kde-workspace. Description --- Upon typing after

Review Request 112236: krunner: Add the full name of completion matches to history

2013-08-24 Thread Harald Hvaal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112236/ --- Review request for kde-workspace and Plasma. Description ---

Re: Review Request 112234: Save krunner dialog size when manually resized

2013-08-24 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112234/#review38463 --- To encouter the destructor, the object has to be really

Re: Review Request 112236: krunner: Add the full name of completion matches to history

2013-08-24 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112236/#review38466 ---

Re: Review Request 112236: krunner: Add the full name of completion matches to history

2013-08-24 Thread Harald Hvaal
On Aug. 24, 2013, 10:08 a.m., Thomas Lübking wrote: kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml, line 274 http://git.reviewboard.kde.org/r/112236/diff/1/?file=184315#file184315line274 ... ;-) yeah, not sure what happened with post-review here, but it's

KF5 kwallet, kwalletd and wallet manager questions

2013-08-24 Thread Valentin Rusu
Hello, Now that frameworks splitting is almost done ;-) with some people even running KF5-based sessions on their systems, I'd like to plan kwallet porting and integration. BTW, I'd like also to announce that I agreed with Michael Leupold to take over the maintainership of KWallet and I'm now

Re: Review Request 112236: krunner: Add the full name of completion matches to history

2013-08-24 Thread Martin Gräßlin
On Aug. 24, 2013, 12:08 p.m., Thomas Lübking wrote: kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml, line 274 http://git.reviewboard.kde.org/r/112236/diff/1/?file=184315#file184315line274 ... ;-) Harald Hvaal wrote: yeah, not sure what happened with

Re: Review Request 112235: Move focus to search field upon typing from result list

2013-08-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112235/#review38471 --- what about cursor up/down keys? You probably want to stay in

Re: Review Request 112235: Move focus to search field upon typing from result list

2013-08-24 Thread Thomas Lübking
On Aug. 24, 2013, 11:15 a.m., Martin Gräßlin wrote: what about cursor up/down keys? You probably want to stay in the results list when using those. pageup/down, home, end, evtl. some modified events (shortcuts)? - Thomas --- This

Re: KF5 kwallet, kwalletd and wallet manager questions

2013-08-24 Thread Albert Astals Cid
El Dissabte, 24 d'agost de 2013, a les 12:31:20, Valentin Rusu va escriure: Hello, Now that frameworks splitting is almost done ;-) with some people even running KF5-based sessions on their systems, I'd like to plan kwallet porting and integration. BTW, I'd like also to announce that I

Re: KF5 kwallet, kwalletd and wallet manager questions

2013-08-24 Thread Kevin Krammer
On Saturday, 2013-08-24, Albert Astals Cid wrote: El Dissabte, 24 d'agost de 2013, a les 12:31:20, Valentin Rusu va escriure: Hello, Now that frameworks splitting is almost done ;-) with some people even running KF5-based sessions on their systems, I'd like to plan kwallet porting and

Frameworks API Documentation

2013-08-24 Thread Allen Winter
First attempt is up: http://api.kde.org/frameworks/kdelibs-apidocs/ Please test it out and let me know what I forgot. I'm working on Search still so I know that's broken.

Review Request 112241: Fix Show Launcher when not running option in taskbar widget

2013-08-24 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/ --- Review request for kde-workspace, Plasma and Eike Hein. Description

Re: Review Request 112235: Move focus to search field upon typing from result list

2013-08-24 Thread Harald Hvaal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112235/ --- (Updated Aug. 24, 2013, 2:42 p.m.) Review request for kde-workspace.

Re: Review Request 112234: Save krunner dialog size when manually resized

2013-08-24 Thread Harald Hvaal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112234/ --- (Updated Aug. 24, 2013, 2:48 p.m.) Review request for kde-workspace.

Re: Review Request 112241: Fix Show Launcher when not running option in taskbar widget

2013-08-24 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112241/#review38481 --- Hm, on the face of it, this patch doesn't really make sense

Re: Review Request 112241: Fix Show Launcher when not running option in taskbar widget

2013-08-24 Thread Bhushan Shah
On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: Hm, on the face of it, this patch doesn't really make sense ... launcher items don't have an associated task, so the function should already return early and the extra condition should be redundant. Unless there's a race condition in the

Re: Review Request 112241: Fix Show Launcher when not running option in taskbar widget

2013-08-24 Thread Eike Hein
On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: Hm, on the face of it, this patch doesn't really make sense ... launcher items don't have an associated task, so the function should already return early and the extra condition should be redundant. Unless there's a race condition in the

Re: Review Request 112241: Fix Show Launcher when not running option in taskbar widget

2013-08-24 Thread Thomas Lübking
On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: Hm, on the face of it, this patch doesn't really make sense ... launcher items don't have an associated task, so the function should already return early and the extra condition should be redundant. Unless there's a race condition in the

Re: Review Request 112241: Fix Show Launcher when not running option in taskbar widget

2013-08-24 Thread Hrvoje Senjan
On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: Hm, on the face of it, this patch doesn't really make sense ... launcher items don't have an associated task, so the function should already return early and the extra condition should be redundant. Unless there's a race condition in the

Re: Review Request 112241: Fix Show Launcher when not running option in taskbar widget

2013-08-24 Thread Bhushan Shah
On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: Hm, on the face of it, this patch doesn't really make sense ... launcher items don't have an associated task, so the function should already return early and the extra condition should be redundant. Unless there's a race condition in the

Re: Review Request 112241: Fix Show Launcher when not running option in taskbar widget

2013-08-24 Thread Thomas Lübking
On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote: Hm, on the face of it, this patch doesn't really make sense ... launcher items don't have an associated task, so the function should already return early and the extra condition should be redundant. Unless there's a race condition in the