Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-14 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/ --- (Updated Sept. 14, 2013, 10:36 p.m.) Review request for KDE Frameworks and

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-14 Thread Mark Gaiser
> On Sept. 14, 2013, 10:46 a.m., David Faure wrote: > > BTW you don't have to test kio_http (requires a webdav account), but please > > port all of kdelibs awaya from the newly deprecated api Easy porting :D Anyway, that will go in separate reviewrequests per slave to port. I will only port t

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-14 Thread Mark Gaiser
> On Sept. 14, 2013, 10:45 a.m., David Faure wrote: > > kioslave/file/file_unix.cpp, line 336 > > > > > > seems to me that it should be indented even more? > > > > > > Anyhow, yes, commit the indenta

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/#review40016 --- BTW you don't have to test kio_http (requires a webdav account)

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/#review40015 --- kioslave/file/file_unix.cpp