Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Mark Gaiser
> On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote: > > Tested it. > > PRE patch: ~17MB/s > > POST patch: ~27MB/s > > > > So in functionality terms this patch makes a file copy from a windows share > > (note: a linux machine sharing through samba, not an actual windows > > machine) much faster. H

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Dawit Alemayehu
> On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote: > > Tested it. > > PRE patch: ~17MB/s > > POST patch: ~27MB/s > > > > So in functionality terms this patch makes a file copy from a windows share > > (note: a linux machine sharing through samba, not an actual windows > > machine) much faster. H

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Mark Gaiser
> On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote: > > Tested it. > > PRE patch: ~17MB/s > > POST patch: ~27MB/s > > > > So in functionality terms this patch makes a file copy from a windows share > > (note: a linux machine sharing through samba, not an actual windows > > machine) much faster. H

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Dawit Alemayehu
> On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote: > > Tested it. > > PRE patch: ~17MB/s > > POST patch: ~27MB/s > > > > So in functionality terms this patch makes a file copy from a windows share > > (note: a linux machine sharing through samba, not an actual windows > > machine) much faster. H

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Mark Gaiser
> On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote: > > Tested it. > > PRE patch: ~17MB/s > > POST patch: ~27MB/s > > > > So in functionality terms this patch makes a file copy from a windows share > > (note: a linux machine sharing through samba, not an actual windows > > machine) much faster. H

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Dawit Alemayehu
> On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote: > > Tested it. > > PRE patch: ~17MB/s > > POST patch: ~27MB/s > > > > So in functionality terms this patch makes a file copy from a windows share > > (note: a linux machine sharing through samba, not an actual windows > > machine) much faster. H

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/#review41277 --- Tested it. PRE patch: ~17MB/s POST patch: ~27MB/s So in functi

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/ --- (Updated Oct. 5, 2013, 3:07 p.m.) Review request for KDE Runtime. Change

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Dawit Alemayehu
> On Oct. 5, 2013, 12:12 p.m., Mark Gaiser wrote: > > Hi Dawit, > > > > Sorry for the late reply. I will test this patch out and report my findings > > later today. I guess this is the long awaited patch that improves the file > > copy speed from SMB to local. Yes, amongst the other fixes I o

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/#review41273 --- Hi Dawit, Sorry for the late reply. I will test this patch out

Re: Review Request 112848: Adding unit tests for kbuttongroup and fixing identation

2013-10-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112848/#review41269 --- One thing I just noticed -- KButtonGroup is deprecated in KF5,