Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-06 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Oct. 6, 2013, 7:24 p.m.) Review request for KDE Frameworks and kd

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-06 Thread Denis Kuplyakov
> On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote: > > kdeui/colors/kcolorschemetoken.h, line 70 > > > > > > using int here loses the type-safety. Why no use the corresponding > > enums? It would also make the

Review Request 113132: Move all Dolphin KPart extensions into dolphin_ext.*

2013-10-06 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113132/ --- Review request for KDE Base Apps and Frank Reininghaus. Repository: kde-ba

Review Request 113131: Added missing slot to bookmarksrunner.*

2013-10-06 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113131/ --- Review request for kde-workspace. Repository: kde-workspace Description

Re: Review Request 113129: proxy configuration: fix setting the use of proxy environment variable

2013-10-06 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113129/ --- (Updated Oct. 6, 2013, 1:25 p.m.) Status -- This change has been mark

Re: Review Request 113129: proxy configuration: fix setting the use of proxy environment variable

2013-10-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113129/#review41300 --- This review has been submitted with commit 623adc32ca7f4c151a0

Re: Review Request 113129: proxy configuration: fix setting the use of proxy environment variable

2013-10-06 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113129/#review41298 --- Ship it! Thanks for the fix. - Dawit Alemayehu On Oct. 6, 2

Review Request 113129: proxy configuration: fix setting the use of proxy environment variable

2013-10-06 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113129/ --- Review request for KDE Base Apps and Dawit Alemayehu. Bugs: 304707 htt

Review Request 113127: Fix click on trash plasmoid when on desktop and widgets are unlocked

2013-10-06 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113127/ --- Review request for kde-workspace and Marco Martin. Bugs: 325330 http:/