Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-11-27 Thread Dawit Alemayehu
> On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote: > > It's been stalled for almost three months now, any chance to see progress > > or should it be discarded? > > Mark Gaiser wrote: > No, it should most certainly not be disgarded. It was even working when i > posted this post up for revie

Re: Review Request 114105: kcm proxy: fix for noProxyFor setting when 'system proxy' type

2013-11-27 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114105/#review44646 --- konqueror/settings/kio/kproxydlg.cpp

Re: Review Request 114048: fix crash in KZip on overwriting existing entries (+ unit test)

2013-11-27 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114048/ --- (Updated Nov. 28, 2013, 1:05 a.m.) Status -- This change has been mar

Re: Review Request 114048: fix crash in KZip on overwriting existing entries (+ unit test)

2013-11-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114048/#review44645 --- This review has been submitted with commit fa0be8a39623b3bc184

Re: Review Request 114048: fix crash in KZip on overwriting existing entries (+ unit test)

2013-11-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114048/#review44640 --- Ship it! Your explanation makes sense, code is clear and valgr

Re: Review Request 114105: kcm proxy: fix for noProxyFor setting when 'system proxy' type

2013-11-27 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114105/ --- (Updated Nov. 27, 2013, 9:22 p.m.) Review request for KDE Base Apps and Da

Re: Review Request 113152: kcm_clock: Check for valid return values of QDateTime::toTime_t()

2013-11-27 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113152/#review44604 --- What's the status here? Has this been submitted? - Lukáš Tinkl

Re: Review Request 113985: Remove no-ops in KCategorizedView

2013-11-27 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113985/ --- (Updated Nov. 27, 2013, 9:52 a.m.) Status -- This change has been mar

Re: Review Request 113985: Remove no-ops in KCategorizedView

2013-11-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113985/#review44561 --- This review has been submitted with commit 48a50fa1fddd22c4063

Re: Review Request 114011: Add ctrl-shift-s as default shortcut for save-as

2013-11-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114011/#review44560 --- This review has been submitted with commit 2ee2233372969a53da5

Re: Review Request 114011: Add ctrl-shift-s as default shortcut for save-as

2013-11-27 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114011/ --- (Updated Nov. 27, 2013, 8:34 a.m.) Status -- This change has been mar