Bump.. Ok to push it?
On Fri, Dec 6, 2013 at 12:44 AM, Mark Gaiser mark...@gmail.com wrote:
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/
Review request for KDE Runtime and KDE Frameworks.
By Mark Gaiser.
*Updated Dec. 5, 2013,
Sorry for the late response. I did not see this email for some reason. None
of the test cases in testRetryDialog hit that assert on my machine. If this
unit test fails on your system, can you please enable the debug area for
KPasswdServer, run the unit test only for testRetryDialog only and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review45467
---
If there are further objections/feedback, please share them.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review45466
---
kioslave/smb/CMakeLists.txt
On Dec. 10, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote:
kioslave/smb/kio_smb_internal.cpp, line 68
http://git.reviewboard.kde.org/r/112463/diff/3/?file=222942#file222942line68
Does it really need QDir::separator()? It seems to me like everything
should be '/'.
could be, but i'm
On Dec. 10, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote:
kioslave/smb/kio_smb_auth.cpp, line 76
http://git.reviewboard.kde.org/r/112463/diff/3/?file=222937#file222937line76
A
xD
Maybe we can just remove this one?
Mark Gaiser wrote:
Just the A
On Oct. 10, 2013, 11:59 a.m., Bernd Buschinski wrote:
This is a bit confussing...
lets sum up the background story:
- kjs(/wtf) loves gcc features
- kjs-cmake filters out (gcc) pedantic
now comes the problem... whats with other compilers?
if you look at the commit message
El Dimarts, 10 de desembre de 2013, a les 08:57:47, Dawit A va escriure:
Sorry for the late response. I did not see this email for some reason. None
of the test cases in testRetryDialog hit that assert on my machine.
Is your Qt compiled in debug or release? Because as my original e-mail says
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113360/#review45497
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113360/
---
(Updated Dec. 10, 2013, 6:47 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/
---
(Updated Dec. 10, 2013, 6:51 p.m.)
Review request for KDE Runtime and KDE
On Dec. 9, 2013, 12:01 p.m., Dario Freddi wrote:
To be completely honest, the QPointer crash doesn't make sense at all and
sounds more like an actual Qt bug more than a PolkitKCM bug. I don't think
that would be a good solution in the big picture.
That said, it's also true that the
On Nov. 29, 2013, 7:32 p.m., Ben Cooksley wrote:
Patch looks fine to me, sucks a bit that the names have to be hardcoded for
certain lists but not much can be done there if that is what the
applications do...
Patch looks fine to me = Ship It! ?
- Burkhard
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review45520
---
Ship it!
- Aleix Pol Gonzalez
On Dec. 10, 2013, 6:51 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/
---
(Updated Dec. 11, 2013, 1:45 a.m.)
Status
--
This change has been
On Tue, Dec 10, 2013 at 1:45 PM, Albert Astals Cid aa...@kde.org wrote:
El Dimarts, 10 de desembre de 2013, a les 08:57:47, Dawit A va escriure:
Sorry for the late response. I did not see this email for some reason.
None
of the test cases in testRetryDialog hit that assert on my machine.
16 matches
Mail list logo
