Re: Failing testcase in kpasswdservertest [kde-runtime]

2013-12-11 Thread Ben Cooksley
On Wed, Dec 11, 2013 at 2:52 PM, Dawit A ada...@kde.org wrote: On Tue, Dec 10, 2013 at 1:45 PM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 10 de desembre de 2013, a les 08:57:47, Dawit A va escriure: Sorry for the late response. I did not see this email for some reason. None of

WARNING: kdepimlibs has been force pushed

2013-12-11 Thread Ben Cooksley
Hi all, Just a little notice that kdepimlibs has been force pushed to reverse a change which had broken the KDE/4.12 release. Due to the nature of the change, a force push was the only method usable to correct it. To adjust your local clones, please perform the following. git remote update git

Regression of KItemWidgetDelegate in 4.12

2013-12-11 Thread Albert Astals Cid
Hi guys, seems that 4.12 is hit by a pretty bad regression in KItemWidgetDelegate (patches that don't seem to have been reviewed, but I won't fight that now) More info at https://bugs.kde.org/show_bug.cgi?id=328528 It seems we're not going to have a fix for today, that is when we are supposed

Re: Failing testcase in kpasswdservertest [kde-runtime]

2013-12-11 Thread Dawit A
Great. I will commit the patch once I get a chance then. Unless of course either you or Albert has already done so. On Wed, Dec 11, 2013 at 3:30 AM, Ben Cooksley bcooks...@kde.org wrote: On Wed, Dec 11, 2013 at 2:52 PM, Dawit A ada...@kde.org wrote: On Tue, Dec 10, 2013 at 1:45 PM, Albert

Re: Failing testcase in kpasswdservertest [kde-runtime]

2013-12-11 Thread Albert Astals Cid
El Dimecres, 11 de desembre de 2013, a les 13:59:57, Dawit A va escriure: Great. I will commit the patch once I get a chance then. Unless of course either you or Albert has already done so. I just did it. Cheers, Albert On Wed, Dec 11, 2013 at 3:30 AM, Ben Cooksley bcooks...@kde.org

Re: Regression of KItemWidgetDelegate in 4.12

2013-12-11 Thread Martin Graesslin
On Wednesday 11 December 2013 19:59:51 Albert Astals Cid wrote: Hi guys, seems that 4.12 is hit by a pretty bad regression in KItemWidgetDelegate (patches that don't seem to have been reviewed, but I won't fight that now) More info at https://bugs.kde.org/show_bug.cgi?id=328528 It seems

Re: Regression of KItemWidgetDelegate in 4.12

2013-12-11 Thread Albert Astals Cid
El Dimecres, 11 de desembre de 2013, a les 20:20:54, Martin Graesslin va escriure: On Wednesday 11 December 2013 19:59:51 Albert Astals Cid wrote: Hi guys, seems that 4.12 is hit by a pretty bad regression in KItemWidgetDelegate (patches that don't seem to have been reviewed, but I won't

Re: Regression of KItemWidgetDelegate in 4.12

2013-12-11 Thread Thomas Lübking
On Mittwoch, 11. Dezember 2013 20:41:28 CEST, Albert Astals Cid wrote: I am hoping that Andras would let us just revert his changes since reading the commit logs seems like they are only optimizations that ended up wrong (i.e. i hope he wasn't really doing any bugfix). Depends on how fast

Re: Regression of KItemWidgetDelegate in 4.12

2013-12-11 Thread Albert Astals Cid
El Dimecres, 11 de desembre de 2013, a les 21:06:20, Thomas Lübking va escriure: On Mittwoch, 11. Dezember 2013 20:41:28 CEST, Albert Astals Cid wrote: I am hoping that Andras would let us just revert his changes since reading the commit logs seems like they are only optimizations that

Re: Regression of KItemWidgetDelegate in 4.12

2013-12-11 Thread Albert Astals Cid
El Dimecres, 11 de desembre de 2013, a les 21:45:42, Albert Astals Cid va escriure: El Dimecres, 11 de desembre de 2013, a les 21:06:20, Thomas Lübking va escriure: On Mittwoch, 11. Dezember 2013 20:41:28 CEST, Albert Astals Cid wrote: I am hoping that Andras would let us just revert his

Re: Regression of KItemWidgetDelegate in 4.12

2013-12-11 Thread Christoph Feck
On Wednesday 11 December 2013 22:37:15 Albert Astals Cid wrote: Actually i've changed my mind, too much people has already upped the version numbers and done preparations, so i've just reverted the commits from Andras and will tag 4.12.0 with that. If Andras appears and says his commits fix