Re: Review Request 114567: RFC: SecondaryActiveChanged signal for advanced screenlocking (global pause MPRIS2, Telepathy N/A status, etc)

2014-01-22 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114567/ --- (Updated Jan. 22, 2014, 11:17 p.m.) Review request for kde-workspace and

Re: Moving KFIleMetadata into KDE SC (documentation and ExtractionResult)

2014-01-22 Thread Albert Astals Cid
El Dimecres, 22 de gener de 2014, a les 18:47:37, Vishesh Handa va escriure: > On Wednesday 22 January 2014 13:09:58 David Edmundson wrote: > > Add COPYING file > > Fixed > > > > > ExtractorPluginManager::fetchExtractors seems odd to me. > > If it can't find any plugins it searches for all p

Re: Moving KFIleMetadata into KDE SC

2014-01-22 Thread Albert Astals Cid
El Dimecres, 22 de gener de 2014, a les 19:15:01, Àlex Fiestas va escriure: > Also you might want to use Qt translation libs so kfilemetadata becomes a Qt > only lib, that might help other desktops/apps to use it (in kf5 you can use > k18n if you want). Do not do that at the moment please, this in

Re: Moving KFIleMetadata into KDE SC

2014-01-22 Thread Àlex Fiestas
· I would add the url and mimetype in the cto, plugins should not be able to change it anyway. · Documentation needs improvement, specially ExtractionResult (making it clear that you should inherit it in order to use the lib). · ExtratorPlugin::mimetypes is pure virtual yet it has an implementati

Re: Moving KFIleMetadata into KDE SC (documentation and ExtractionResult)

2014-01-22 Thread Vishesh Handa
On Wednesday 22 January 2014 13:09:58 David Edmundson wrote: > Add COPYING file Fixed > > ExtractorPluginManager::fetchExtractors seems odd to me. > If it can't find any plugins it searches for all plugins that start > the same prefix. > > I assume it's designed so I can have a plugin with

Re: Splitting kde-workspace and kde-runtime proposal

2014-01-22 Thread Kevin Ottens
On Tuesday 21 January 2014 12:05:26 Antonis Tsiapaliokas wrote: > > 1) Create two different groups named plasma-workspace and > > plasma-desktop like frameworks > > 2) Split out every component into individual repos > > 3) Assign repos to the related group. > > > > Advantages: > > > > 1) Easy to

Re: Review Request 115191: use renamed dbus interface files for kstatusnotifier

2014-01-22 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115191/ --- (Updated Jan. 22, 2014, 1:40 p.m.) Status -- This change has been ma

Re: Review Request 115191: use renamed dbus interface files for kstatusnotifier

2014-01-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115191/#review48025 --- This review has been submitted with commit 20ac680f5011020e56

Re: Review Request 115191: use renamed dbus interface files for kstatusnotifier

2014-01-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115191/#review48017 --- Ship it! Ship It! - Martin Klapetek On Jan. 21, 2014, 6:42

Re: Moving KFIleMetadata into KDE SC (documentation and ExtractionResult)

2014-01-22 Thread David Edmundson
Add COPYING file ExtractorPluginManager::fetchExtractors seems odd to me. If it can't find any plugins it searches for all plugins that start the same prefix. I assume it's designed so I can have a plugin with the mimetype audio/ that will still match the file mimetype audio/mp3 But this mean

Re: Re: Splitting kde-workspace and kde-runtime proposal

2014-01-22 Thread Martin Gräßlin
On Tuesday 21 January 2014 13:12:58 David Hubner wrote: > > In the plasma sprint we have done a session to plan what we are going to > > do > > with kde-workspace/kde-runtime repositories, here is the proposal we came > > with. > > > > We are going to create 2 new repos called plasma-desktop and >

Re: Splitting kde-workspace and kde-runtime proposal

2014-01-22 Thread David Hubner
> In the plasma sprint we have done a session to plan what we are going to do > with kde-workspace/kde-runtime repositories, here is the proposal we came > with. > > We are going to create 2 new repos called plasma-desktop and > plasma-workspace, we decided to use plasma as a prefix so in the futu

Re: Moving KFIleMetadata into KDE SC

2014-01-22 Thread Vishesh Handa
On Wednesday 22 January 2014 00:14:27 Albert Astals Cid wrote: > El Dimarts, 21 de gener de 2014, a les 11:56:11, Vishesh Handa va escriure: > > On Monday 20 January 2014 22:37:12 Albert Astals Cid wrote: > > > Please have a look at the const-ness of the methods, there's lots of > > > "geters" that

Re: Moving KFIleMetadata into KDE SC (documentation and ExtractionResult)

2014-01-22 Thread Vishesh Handa
On Wednesday 22 January 2014 00:23:45 Albert Astals Cid wrote: > El Divendres, 17 de gener de 2014, a les 18:03:31, Vishesh Handa va escriure: > > Hey guys > > > > I should have posted this with the Baloo thread, but since I did not - > > > > WIth KDE SC 4.10, Nepomuk dropped support for Strigi

Re: Moving KFIleMetadata into KDE SC

2014-01-22 Thread Vishesh Handa
On Wednesday 22 January 2014 00:16:05 Albert Astals Cid wrote: > El Dimarts, 21 de gener de 2014, a les 11:56:33, Vishesh Handa va escriure: > > On Monday 20 January 2014 22:38:52 Albert Astals Cid wrote: > > > Also make sure all the classes have a d-pointer in case they need to be > > > expanded i