Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

2014-02-06 Thread Àlex Fiestas
On Feb. 5, 2014, 7:18 p.m., Michael Pyne wrote: kwalletd/backend/kwalletbackend.cc, line 635 https://git.reviewboard.kde.org/r/115497/diff/1/?file=242022#file242022line635 Seems to be no error checking here, if this fails and we overwrite the hashed passwords on disk, couldn't

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

2014-02-06 Thread Àlex Fiestas
On Feb. 5, 2014, 7:18 p.m., Michael Pyne wrote: kwalletd/backend/kwalletbackend.cc, line 130 https://git.reviewboard.kde.org/r/115497/diff/1/?file=242022#file242022line130 The salt here seems to be based off of the user's login-name, which can change (for instance, someday my KDE

Re: Review Request 115515: [oxygen] Check whether we are on platform X11 before calling into xcb

2014-02-06 Thread Martin Gräßlin
On Feb. 6, 2014, 12:26 p.m., Hugo Pereira Da Costa wrote: @Martin in kstyles/oxygen you are missing oxygenblurhelper (and likely kate will crash when showing a tooltip) in kwin/clients/oxygen (but might be another review) oxygenclient oxygensizegrip config/oxygendetectwidget

Re: Review Request 115515: [oxygen] Check whether we are on platform X11 before calling into xcb

2014-02-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115515/ --- (Updated Feb. 6, 2014, 1:22 p.m.) Review request for kde-workspace and

KDE Review: Move kqtquickcharts to KDE Edu

2014-02-06 Thread Sebastian Gottfried
Hi everyone, kqtquickcharts (formerly known as kqmlgraphs) provides components for line and bar charts for QtQuick applications. As discussed earlier, I want to release the project as soon as possible (read: 4.13) so KTouch and artikulate can use it. The release of artikulate depends on this,

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

2014-02-06 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115497/ --- (Updated Feb. 6, 2014, 3:28 p.m.) Review request for KDE Runtime, Teo

Review Request 115519: Do not use KDE_VERSION_STRING for workspace applications

2014-02-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115519/ --- Review request for kde-workspace and Release Team. Repository: