Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

> On Feb. 7, 2014, 5:14 a.m., Michael Pyne wrote: > > kwalletd/backend/kwalletbackend.cc, line 387 > > > > > > Again, might want to add error-checking here. If the salt can't be > > saved for whatever reason t

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115497/#review49315 --- I've had a chance to download the patch and restart the deskto

Re: Review Request 115492: Add WebP detection from content in the mime package file

> On Feb. 8, 2014, 5:41 p.m., David Faure wrote: > > Please consider submitting this mimetype to freedesktop.org.xml instead. > > > > https://bugs.freedesktop.org > > David Faure wrote: > OK, s/instead/in addition/. Sorry, failed to record a conversation that happened on irc. Basically:

Re: Review Request 115492: Add WebP detection from content in the mime package file

> On Feb. 8, 2014, 5:41 p.m., David Faure wrote: > > Please consider submitting this mimetype to freedesktop.org.xml instead. > > > > https://bugs.freedesktop.org OK, s/instead/in addition/. - David --- This is an automatically generat

Re: Review Request 115492: Add WebP detection from content in the mime package file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115492/#review49268 --- Please consider submitting this mimetype to freedesktop.org.xm

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

> On Feb. 8, 2014, 2:34 p.m., Thomas Lübking wrote: > > Here's my vote then. > > Unless there's concern, push it "in some days™" (ie. tuesday or so, should > > leave enough time to cry out) "push it" sounds like I should push it, however I can't do it, as I do not have a dev account. Could you

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/#review49252 --- Ship it! Here's my vote then. Unless there's concern, push it

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > posi

Re: Review Request 115408: Fix alignment for mime icon in kpropertiesdialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/ --- (Updated Feb. 8, 2014, 10:02 a.m.) Review request for kdelibs and Frank R