Re: KDE Review: Move LabPlot to extragear.

2014-02-13 Thread Sven Brauch
Hello! On Tuesday 11 February 2014 21:32:29 Alexander Semke wrote: couple of days ago LabPlot-project [1] decided to move to KDE and to become a part of KDE Edu and to collaborate closer with people involved in other projects on KDE Edu [2]. After almost four years of development we had the

Re: Moving Milou to Extragear

2014-02-13 Thread Vishesh Handa
On Wednesday, February 12, 2014 11:56:27 PM Albert Astals Cid wrote: El Dimarts, 11 de febrer de 2014, a les 11:55:01, Vishesh Handa va escriure: Hello people I've been developing Milou for quite some time now and I think it would be best to move it into extragear so that a release can

Re: Moving Milou to Extragear

2014-02-13 Thread Vishesh Handa
On Wednesday, February 12, 2014 11:57:56 PM Albert Astals Cid wrote: Also you can optimize qDeleteAll(m_mapping.values()); to qDeleteAll(m_mapping); Thanks. Fixed -- Vishesh Handa

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-13 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- (Updated Feb. 13, 2014, 11:14 a.m.) Review request for kde-workspace,

Re: Moving Milou to Extragear

2014-02-13 Thread Burkhard Lück
Am Donnerstag, 13. Februar 2014, 10:38:34 schrieb Vishesh Handa: On Wednesday, February 12, 2014 11:56:27 PM Albert Astals Cid wrote: I'd also say that your catalog isn't getting loaded (i.e. your catalog name is wrong). Is it? Messages.sh #! /usr/bin/env bash $XGETTEXT `find .

Re: KDE Review: Move LabPlot to extragear.

2014-02-13 Thread Vishesh Handa
Hey I've just taken a cursory glance. Some things that I noticed - 1. The recommended mailing list is sourceforge - Do you want to move to KDE? I'm not sure if this is required by the manifesto or not. We do enforce the usage of kde-infrastructure 2. AUTHORS - Do you really need to obfuscate

Re: Moving Milou to Extragear

2014-02-13 Thread Lukáš Tinkl
Dne 13.2.2014 11:28, Burkhard Lück napsal(a): Am Donnerstag, 13. Februar 2014, 10:38:34 schrieb Vishesh Handa: On Wednesday, February 12, 2014 11:56:27 PM Albert Astals Cid wrote: I'd also say that your catalog isn't getting loaded (i.e. your catalog name is wrong). Is it? Messages.sh #!

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

2014-02-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115497/#review49710 --- This review has been submitted with commit

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

2014-02-13 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115497/ --- (Updated Feb. 13, 2014, 2:31 p.m.) Status -- This change has been

Review Request 115726: Deafult for not executing kwalletmanager once a wallet is open

2014-02-13 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115726/ --- Review request for KDE Runtime, kde-workspace and Plasma. Repository:

Review Request 115728: Deafult for not executing kwalletmanager once a wallet is open

2014-02-13 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115728/ --- Review request for KDE Runtime, kde-workspace and Plasma. Repository:

Review Request 115727: Deafult for not executing kwalletmanager once a wallet is open

2014-02-13 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115727/ --- Review request for KDE Runtime, kde-workspace and Plasma. Repository:

Re: Review Request 115726: Deafult for not executing kwalletmanager once a wallet is open

2014-02-13 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115726/ --- (Updated Feb. 13, 2014, 5:13 p.m.) Review request for KDE Runtime,

Re: KDE Review: Move LabPlot to extragear.

2014-02-13 Thread Albert Astals Cid
El Dijous, 13 de febrer de 2014, a les 08:21:48, Alexander Semke va escriure: Hi, Do you really need that embedded liborigin? The development of this code was originally initiated in LabPlot and got later contributions from other projects. A library was created. It is/was used for the

Re: Review Request 114907: Make KFontUtils::adaptFontSize be a bit more exact

2014-02-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114907/#review49745 --- ping? - Albert Astals Cid On Jan. 9, 2014, 10:22 p.m.,

Re: KDE Review: Move LabPlot to extragear.

2014-02-13 Thread Yuri Chornoivan
написане Thu, 13 Feb 2014 01:05:39 +0200, Albert Astals Cid aa...@kde.org: El Dimarts, 11 de febrer de 2014, a les 21:32:29, Alexander Semke va escriure: Hi all, couple of days ago LabPlot-project [1] decided to move to KDE and to become a part of KDE Edu and to collaborate closer with

Re: KDE Review: Move LabPlot to extragear.

2014-02-13 Thread Alexander Semke
Hi, Do you really need that embedded liborigin? The development of this code was originally initiated in LabPlot and got later contributions from other projects. A library was created. It is/was used for the import of Origin files. At the moment we don't import anything but ascii files.

Re: KDE Review: Move LabPlot to extragear.

2014-02-13 Thread Alexander Semke
Hi, A few things I noticed: - why not put the compile flags from the ./compile script in CMakeLists.txt? I'll move the flags to CMakeLists.txt. - I added a file data source, then a worksheet and an xy plot and it crashed [1] Huch. I cannot reproduce this. Does this error happens on your

Re: Review Request 115727: Deafult for not executing kwalletmanager once a wallet is open

2014-02-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115727/#review49755 --- Ship it! Makes a lot of sense. Pedantic Comments: fix the

Re: Review Request 115728: Deafult for not executing kwalletmanager once a wallet is open

2014-02-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115728/#review49756 --- Ship it! Ship It! - David Edmundson On Feb. 13, 2014,

Re: KDE Review: Move LabPlot to extragear.

2014-02-13 Thread Sven Brauch
Hi, On Thursday 13 February 2014 22:04:32 Alexander Semke wrote: Huch. I cannot reproduce this. Does this error happens on your system independent of the plot type (box plot etc.) you're trying to create? Sorry for the noise, I apparently didn't install the XMLGUI files properly. Thus the