Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116524/ --- (Updated March 13, 2014, 5:05 a.m.) Status -- This change has been m

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/#review52862 --- This review has been submitted with commit 2dbcc83c25d9b2a8a2

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/ --- (Updated March 13, 2014, 5:05 a.m.) Status -- This change has been m

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116524/#review52861 --- This review has been submitted with commit d6453435f0d475e16b

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
> On March 12, 2014, 2:39 p.m., David Faure wrote: > > Thanks. > > > > I hope we don't get into the case of "Unknown Size" when the size is > > actually 0, though. That case would still be buggy, and I'm not sure how we > > could fix it. Well I could think of one scenario where that could pot

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

2014-03-12 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116555/ --- (Updated March 13, 2014, 12:33 a.m.) Status -- This change has been

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116555/#review52854 --- This review has been submitted with commit f2fe3e75b4ba12d0f9

Re: Is kpovmodeler still valid or should it be removed

2014-03-12 Thread Albert Astals Cid
El Dimecres, 12 de març de 2014, a les 23:06:00, Martin Koller va escriure: > On Wednesday 12 March 2014 19:44:39 Albert Astals Cid wrote: > > El Dimecres, 12 de març de 2014, a les 15:04:01, Martin Koller va escriure: > > > On Monday 10 March 2014 12:36:59 Burkhard Lück wrote: > > > > extragear/g

Re: Is kpovmodeler still valid or should it be removed

2014-03-12 Thread Martin Koller
On Wednesday 12 March 2014 19:44:39 Albert Astals Cid wrote: > El Dimecres, 12 de març de 2014, a les 15:04:01, Martin Koller va escriure: > > On Monday 10 March 2014 12:36:59 Burkhard Lück wrote: > > > extragear/graphics has more candidates for this question: > > > > > > kuickshow: > > > no devel

Re: Review Request 115864: kio_http: fixes for 30X response code redirection handling

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115864/#review52846 --- This review has been submitted with commit 16052fed9be0cb7d15

Re: Review Request 116048: Remove Content-Type header when redirecting to GET

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116048/#review52847 --- This review has been submitted with commit 907898a49d1e9fac61

Re: Review Request 115689: Fix khtml/ecma/xmlhttprequest.cpp to properly handle HEAD requests

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115689/#review52842 --- This review has been submitted with commit 3d857d2171d4182954

Re: Review Request 115651: Fix HTTP redirection handling (3XX status code)

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115651/#review52841 --- This review has been submitted with commit 863f775bacf0a8f7a8

Re: Is kpovmodeler still valid or should it be removed

2014-03-12 Thread Albert Astals Cid
El Dimecres, 12 de març de 2014, a les 15:04:01, Martin Koller va escriure: > On Monday 10 March 2014 12:36:59 Burkhard Lück wrote: > > extragear/graphics has more candidates for this question: > > > > kuickshow: > > no development since > 4 years > > needs an old no longer available library imlib

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/#review52761 --- Ship it! Thanks. I hope we don't get into the case of "Unkno

Re: Is kpovmodeler still valid or should it be removed

2014-03-12 Thread Martin Koller
On Monday 10 March 2014 12:36:59 Burkhard Lück wrote: > extragear/graphics has more candidates for this question: > > kuickshow: > no development since > 4 years > needs an old no longer available library imlib1 to build > no deb packages provided BTW: I made a replacement application for this:

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/ --- (Updated March 12, 2014, 1:26 p.m.) Review request for kdelibs and David

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116524/#review52744 --- Ship it! Ship It! - David Faure On March 12, 2014, 11:36 a

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/#review52743 --- kioslave/ftp/ftp.cpp

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/ --- (Updated March 12, 2014, 12:47 p.m.) Review request for kdelibs and David

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/ --- (Updated March 12, 2014, 11:39 a.m.) Review request for kdelibs and David

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116524/ --- (Updated March 12, 2014, 11:36 a.m.) Review request for kdelibs and David

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116523/ --- (Updated March 12, 2014, 11:35 a.m.) Review request for kdelibs and David

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread David Faure
> On March 4, 2014, 7:42 p.m., David Faure wrote: > > I don't get it. What's the problem with sending a mimetype for empty files? > > I would think this is actually expected - for all files, including empty > > ones. Why does this fix the bug? > > Dawit Alemayehu wrote: > It fails and ends

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread Dawit Alemayehu
> On March 4, 2014, 7:42 p.m., David Faure wrote: > > I don't get it. What's the problem with sending a mimetype for empty files? > > I would think this is actually expected - for all files, including empty > > ones. Why does this fix the bug? > > Dawit Alemayehu wrote: > It fails and ends

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116524/#review52715 --- kioslave/ftp/ftp.cpp

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-12 Thread David Faure
> On March 4, 2014, 7:42 p.m., David Faure wrote: > > I don't get it. What's the problem with sending a mimetype for empty files? > > I would think this is actually expected - for all files, including empty > > ones. Why does this fix the bug? > > Dawit Alemayehu wrote: > It fails and ends