Re: Review Request 116097: No longer use strlcpy in kstartupconfig

2014-03-14 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116097/#review52934 --- It works for me (I get kstartupconfig5 built). If it works in

Re: Review Request 116784: Fix incorrect use of KDateTime.toTime_t in kio_http

2014-03-14 Thread David Jarvie
On March 13, 2014, 5:30 p.m., David Jarvie wrote: The handling of return values from KDateTime::toTime_t() in the existing kio_http code is not correct, because the return value's type is implicitly cast to other types before being checked. For example, in one place it is cast to

Re: Review Request 116784: Fix incorrect use of KDateTime.toTime_t in kio_http

2014-03-14 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116784/#review52940 --- kioslave/http/http.cpp