Re: Review Request 117174: Fix installing and removing desktop plasma theme packages.

2014-03-31 Thread Andrei Amuraritei
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117174/ --- (Updated April 1, 2014, 12:18 a.m.) Review request for kdelibs, Albert As

Re: Review Request 117157: Unlock session via DBus

2014-03-31 Thread Ingo Klöcker
On Sunday 30 March 2014 15:36:29 Thiago Macieira wrote: > Em seg 31 mar 2014, às 00:01:13, Thomas Lübking escreveu: > > > If they can gain access to a TTY login we are already screwed > > > > leaving aside the present issue (/MainApplication quit being exposed > > to dbus) and given ptrace (gdb so

Re: Review Request 117157: Unlock session via DBus

2014-03-31 Thread Thiago Macieira
Em seg 31 mar 2014, às 08:55:05, Martin Gräßlin escreveu: > Personally I have to disagree. To me the graphical login is a an asset > which needs to be protected in a stronger way. Access to a tty should not > equal access to the graphical system. The fact that X is broken should not > result in us

Re: KF5: Parsing times with timezone abbreviations

2014-03-31 Thread Kevin Kofler
David Jarvie wrote: > They can't just be ignored for small countries, since they may contain a > daylight savings time indication. Except for one "evil" hour every year, a given local time with the date included is either necessarily DST or necessarily non-DST. That said, sure, if we are about t

Re: Review Request 117174: Fix installing and removing desktop plasma theme packages.

2014-03-31 Thread Sebastian Kügler
> On March 31, 2014, 4:04 p.m., Sebastian Kügler wrote: > > plasma/packagestructure.cpp, line 653 > > > > > > { go on the next line (here and elsewhere) > > Andrei Amuraritei wrote: > Sorry don't get what yo

Re: Review Request 117174: Fix installing and removing desktop plasma theme packages.

2014-03-31 Thread Andrei Amuraritei
> On March 31, 2014, 4:04 p.m., Sebastian Kügler wrote: > > plasma/packagestructure.cpp, line 659 > > > > > > This is going to be funny if you have multiple packages in the path > > you're specifying here, it wi

Re: Review Request 117174: Fix installing and removing desktop plasma theme packages.

2014-03-31 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117174/#review54702 --- plasma/packagestructure.cpp

Re: KF5: Parsing times with timezone abbreviations

2014-03-31 Thread David Jarvie
On Mon, March 31, 2014 11:53 am, Kevin Kofler wrote: > Thiago Macieira wrote: >> Time zone abbreviations are useless, since they are not unique. Simply >> strip them out of your string before passing to QDateTime. > > Nice theory, but there is no other way to know what time this actually is. > Unle

Re: Tests still failing in 4.13

2014-03-31 Thread Vishesh Handa
On Monday, March 31, 2014 01:42:01 AM Albert Astals Cid wrote: > Hello people, at the moment we have various 4.13 projects failing. Hello > I am also open to be convinced that the test is right and that it's > unfixable to run correctly on jenkins, but make sure you are really > convincing if you

Re: KF5: Parsing times with timezone abbreviations

2014-03-31 Thread Kevin Kofler
Thiago Macieira wrote: > Time zone abbreviations are useless, since they are not unique. Simply > strip them out of your string before passing to QDateTime. Nice theory, but there is no other way to know what time this actually is. Unless you can offer a mapping from latitude and longitude to tim

Re: Review Request 112294: Implement multi-seat support in KDM

2014-03-31 Thread Oswald Buddenhagen
> On March 28, 2014, 10:59 a.m., Oswald Buddenhagen wrote: > > kdm/backend/dm.c, line 1397 > > > > > > that seems questionable to me. why are you re-defining the display to > > be permanent? when the seat goes

Re: Help splitting kde-workspace

2014-03-31 Thread Martin Klapetek
On Mon, Mar 31, 2014 at 6:50 AM, Aleix Pol wrote: > > Hi, > I've been looking into the issue with Nicolás (aka PovAddict) and we > managed to figure out all repositories history except for plasma-workspace > and plasma-desktop. The problem was that not only they were moved now, but > they were mo

Re: Re: Review Request 117157: Unlock session via DBus

2014-03-31 Thread Martin Gräßlin
On Sunday 30 March 2014 18:06:52 Thiago Macieira wrote: > > Leaving access to an open shell is certainly bad enough - beyond question. > > The question is whether gaining direct access to a running session and > > random open clients (and leaving the stage untraced) is more valuable and > > thus wo