Re: Review Request 112294: Implement multi-seat support in KDM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112294/ --- (Updated April 6, 2014, 10:01 p.m.) Review request for kde-workspace and

Re: Review Request 117400: kdm: read DesktopNames from session file and export XDG_CURRENT_DESKTOP from it Add DesktopNames key to kdm sessions files.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117400/ --- (Updated April 6, 2014, 9:43 p.m.) Review request for kde-workspace and O

Re: Review Request 117400: kdm: read DesktopNames from session file and export XDG_CURRENT_DESKTOP from it Add DesktopNames key to kdm sessions files.

> On April 6, 2014, 8:36 p.m., Oswald Buddenhagen wrote: > > kdm/backend/client.c, line 1820 > > > > > > for pedantry, you actually should free() desktopNames (to be buf). Oh. I thought about it, but saw other

Re: Review Request 117400: kdm: read DesktopNames from session file and export XDG_CURRENT_DESKTOP from it Add DesktopNames key to kdm sessions files.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117400/#review55089 --- kdm/backend/client.c

Re: Review Request 112294: Implement multi-seat support in KDM

> On March 28, 2014, 10:59 a.m., Oswald Buddenhagen wrote: > > kdm/backend/server.c, line 85 > > > > > > is this really necessary? i would expect it to be the default. Its not necessary (and the code path in the

Re: Review Request 112294: Implement multi-seat support in KDM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112294/ --- (Updated April 6, 2014, 8:16 p.m.) Review request for kde-workspace and O

Re: Configuration files transfer

On Friday 04 Apr 2014 21:36:11 Luca Beltrame wrote: > David Faure wrote: > > Kevin Krammer had thoughts on the topic - iirc along the lines of "every > > application should take care of migrating the relevant data" ? (cc'ed) > > To give more context on this question: kactivities (KF5 based) can be

Re: Configuration files transfer

David Faure wrote: > Kevin Krammer had thoughts on the topic - iirc along the lines of "every > application should take care of migrating the relevant data" ? (cc'ed) To give more context on this question: kactivities (KF5 based) can be used with a 4.x software stack, however it uses the XDG co

Re: Review Request 117345: Fix crash in KIO due to exposing inconsistent views of internal data.

> On April 5, 2014, 9:16 p.m., David Faure wrote: > > Did you try running the unittests in kio/tests ? > > Simeon Bird wrote: > The kdelibs 4 tests all pass. I don't have a working 5 setup, so I didn't > test the 5 tests, if they are different. The KF5 tests are the same, no worries about

Re: Review Request 113969: Do not assume every items have the same height

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113969/#review55062 --- I don't know this code so unfortunately I can't really approve

Review Request 117400: kdm: read DesktopNames from session file and export XDG_CURRENT_DESKTOP from it Add DesktopNames key to kdm sessions files.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117400/ --- Review request for kde-workspace and Oswald Buddenhagen. Repository: kde-

Review Request 117399: kreadconfig: adapt to moving to kde-cli-tools out of the top level directory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117399/ --- Review request for KDE Runtime. Repository: kde-runtime Description ---