On April 6, 2014, 7:48 a.m., David Faure wrote:
kdeui/itemviews/kcategorizedview.cpp, line 795
https://git.reviewboard.kde.org/r/113969/diff/4/?file=215105#file215105line795
Coding style comment: some code paths use break (which results in
return QModelIndex() at the end) and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113969/
---
(Updated April 22, 2014, 6:13 a.m.)
Review request for kdelibs, David
On March 26, 2014, 11:07 p.m., Thomas Lübking wrote:
you could sighup or sigusr the greeter process and have it
setImmediateLock(true);
desktopResized();
in return
Wolfgang Bauer wrote:
I agree, this would be a bit nicer...
But I tried it and cannot get it to work.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/#review56190
---
see minor nitpicks, but in general the patch seems fine and
On April 22, 2014, 7:34 p.m., Thomas Lübking wrote:
ksmserver/screenlocker/greeter/main.cpp, line 89
https://git.reviewboard.kde.org/r/117091/diff/2/?file=262501#file262501line89
ooc.: what's wrong about just:
signal(SIGUSR1, signalHandler); ?
signal() is deprecated,
On April 22, 2014, 5:34 p.m., Thomas Lübking wrote:
ksmserver/screenlocker/greeter/main.cpp, line 89
https://git.reviewboard.kde.org/r/117091/diff/2/?file=262501#file262501line89
ooc.: what's wrong about just:
signal(SIGUSR1, signalHandler); ?
Wolfgang Bauer wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/#review56209
---
ksmserver/screenlocker/greeter/main.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/
---
(Updated April 22, 2014, 9:56 p.m.)
Review request for kde-workspace,
On April 22, 2014, 9:48 p.m., Thomas Lübking wrote:
ksmserver/screenlocker/greeter/main.cpp, line 38
https://git.reviewboard.kde.org/r/117091/diff/3/?file=267733#file267733line38
/me would not insist on newline, but there needs to be a blank after
the if
if (!m_instance)
On April 22, 2014, 7:34 p.m., Thomas Lübking wrote:
ksmserver/screenlocker/greeter/main.cpp, line 89
https://git.reviewboard.kde.org/r/117091/diff/2/?file=262501#file262501line89
ooc.: what's wrong about just:
signal(SIGUSR1, signalHandler); ?
Wolfgang Bauer wrote:
On April 22, 2014, 5:34 p.m., Thomas Lübking wrote:
ksmserver/screenlocker/greeter/main.cpp, line 89
https://git.reviewboard.kde.org/r/117091/diff/2/?file=262501#file262501line89
ooc.: what's wrong about just:
signal(SIGUSR1, signalHandler); ?
Wolfgang Bauer wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117644/
---
Review request for kde-workspace and Plasma.
Bugs: 224200
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117644/
---
(Updated April 22, 2014, 10:41 p.m.)
Review request for kde-workspace
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/
---
(Updated April 22, 2014, 10:34 p.m.)
Review request for kde-workspace,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117644/#review56219
---
Ship it!
from here - see veto condition in the other RR (i
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117644/#review56240
---
would you please also adapt that for plasma-workspace repo
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/#review56241
---
Is that only relevant for the legacy (XSS) locker or also for
17 matches
Mail list logo
