Re: Kronometer now in KDE Review

2014-04-23 Thread GEO
Final screenshot with all these changes: http://abload.de/img/kronometerdrkjq.png I would agree with Thomas, the right align is not the best idea imho.

Re: Kronometer now in KDE Review

2014-04-23 Thread Thomas Lübking
On Mittwoch, 23. April 2014 13:17:02 CEST, Elvis Angelaccio wrote: I don't understand. Since there are only numbers I think that your point is already accomplished. Nope. To get monospace glyphs for sure, you must select a monospace font - otherwise you're going by luck. At least on my

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-23 Thread Wolfgang Bauer
On April 23, 2014, 7:41 a.m., Martin Gräßlin wrote: Is that only relevant for the legacy (XSS) locker or also for the new locker? I'm just wondering whether it needs to be ported to master Yes. I just tried, and the screen locker in master does have the same problem. I wasn't able yet to

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

2014-04-23 Thread Wolfgang Bauer
On April 23, 2014, 7:36 a.m., Martin Gräßlin wrote: would you please also adapt that for plasma-workspace repo (new master)? Yes, I will. Should I create a new review request for that, or should I just submit it? - Wolfgang ---

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

2014-04-23 Thread Martin Gräßlin
On April 23, 2014, 7:36 a.m., Martin Gräßlin wrote: would you please also adapt that for plasma-workspace repo (new master)? Wolfgang Bauer wrote: Yes, I will. Should I create a new review request for that, or should I just submit it? The code looks pretty straight forward

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-23 Thread Wolfgang Bauer
On April 23, 2014, 7:41 a.m., Martin Gräßlin wrote: Is that only relevant for the legacy (XSS) locker or also for the new locker? I'm just wondering whether it needs to be ported to master Wolfgang Bauer wrote: Yes. I just tried, and the screen locker in master does have the same

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-23 Thread Martin Gräßlin
On April 23, 2014, 7:41 a.m., Martin Gräßlin wrote: Is that only relevant for the legacy (XSS) locker or also for the new locker? I'm just wondering whether it needs to be ported to master Wolfgang Bauer wrote: Yes. I just tried, and the screen locker in master does have the same

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-23 Thread Wolfgang Bauer
On April 23, 2014, 5:43 p.m., Martin Gräßlin wrote: ksmserver/screenlocker/greeter/main.cpp, line 34 https://git.reviewboard.kde.org/r/117091/diff/5/?file=267770#file267770line34 I'm wondering about the variable naming. It's m_ so one would assume it's a member variable, but that

Re: Review Request 117174: Fix installing and removing desktop plasma theme packages.

2014-04-23 Thread Andrei Amuraritei
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117174/ --- (Updated April 23, 2014, 11:04 p.m.) Review request for kdelibs, Aaron

Re: Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

2014-04-23 Thread Andrei Amuraritei
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117175/ --- (Updated April 23, 2014, 11:05 p.m.) Review request for KDE Runtime,