Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-23 Thread Martin Gräßlin
> On April 23, 2014, 5:43 p.m., Martin Gräßlin wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 34 > > > > > > I'm wondering about the variable naming. It's m_ so one would assume > > it's a member variab

Re: Review Request 117174: Fix installing and removing desktop plasma theme packages.

2014-04-23 Thread Andrei Amuraritei
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117174/ --- (Updated April 23, 2014, 11:04 p.m.) Review request for kdelibs, Aaron J.

Re: Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

2014-04-23 Thread Andrei Amuraritei
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117175/ --- (Updated April 23, 2014, 11:05 p.m.) Review request for KDE Runtime, Aaro

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-23 Thread Wolfgang Bauer
> On April 23, 2014, 5:43 p.m., Martin Gräßlin wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 34 > > > > > > I'm wondering about the variable naming. It's m_ so one would assume > > it's a member variab

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-23 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/ --- (Updated April 23, 2014, 11:26 p.m.) Review request for kde-workspace, Pl

Re: Review Request 117095: rename kdebugdialog to kdebugdialog5 for coinstallability

2014-04-23 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117095/ --- (Updated April 23, 2014, 3:51 p.m.) Status -- This change has been d

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-23 Thread Martin Gräßlin
> On April 23, 2014, 7:41 a.m., Martin Gräßlin wrote: > > Is that only relevant for the legacy (XSS) locker or also for the new > > locker? I'm just wondering whether it needs to be ported to master > > Wolfgang Bauer wrote: > Yes. I just tried, and the screen locker in master does have the

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/#review56294 --- ksmserver/screenlocker/greeter/main.cpp

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-23 Thread Wolfgang Bauer
> On April 23, 2014, 7:41 a.m., Martin Gräßlin wrote: > > Is that only relevant for the legacy (XSS) locker or also for the new > > locker? I'm just wondering whether it needs to be ported to master > > Wolfgang Bauer wrote: > Yes. I just tried, and the screen locker in master does have the

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

2014-04-23 Thread Martin Gräßlin
> On April 23, 2014, 7:36 a.m., Martin Gräßlin wrote: > > would you please also adapt that for plasma-workspace repo (new master)? > > Wolfgang Bauer wrote: > Yes, I will. > > Should I create a new review request for that, or should I just submit it? The code looks pretty straight

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

2014-04-23 Thread Wolfgang Bauer
> On April 23, 2014, 7:36 a.m., Martin Gräßlin wrote: > > would you please also adapt that for plasma-workspace repo (new master)? Yes, I will. Should I create a new review request for that, or should I just submit it? - Wolfgang --- T

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-23 Thread Wolfgang Bauer
> On April 23, 2014, 7:41 a.m., Martin Gräßlin wrote: > > Is that only relevant for the legacy (XSS) locker or also for the new > > locker? I'm just wondering whether it needs to be ported to master Yes. I just tried, and the screen locker in master does have the same problem. I wasn't able ye

Re: Kronometer now in KDE Review

2014-04-23 Thread Elvis Angelaccio
Hi Thomas, 2014-04-19 11:24 GMT+02:00 Thomas Lübking : > Am Freitag, 18. April 2014 schrieb Elvis Angelaccio : > > > Final screenshot with all these changes: > http://abload.de/img/kronometerdrkjq.png > > I think by "right align", Ingo meant numerical, not pixelwise, ie the > display should be >

Re: Kronometer now in KDE Review

2014-04-23 Thread Thomas Lübking
On Mittwoch, 23. April 2014 13:17:02 CEST, Elvis Angelaccio wrote: I don't understand. Since there are only numbers I think that your point is already accomplished. Nope. To get monospace glyphs for sure, you must select a monospace font - otherwise you're going by luck. At least on my syste

Re: Kronometer now in KDE Review

2014-04-23 Thread GEO
> Final screenshot with all these changes: > http://abload.de/img/kronometerdrkjq.png I would agree with Thomas, the right align is not the best idea imho.