Re: Review Request 117957: kcm_fonts: correctly restore default configuration values

2014-07-06 Thread Andrea Iacovitti
> On Mag. 19, 2014, 9:30 a.m., Sebastian Kügler wrote: > > This will likely need a backport to Plasma 5. The code there has moved to > > the plasma-desktop repo, under kcms/fonts. ok - Andrea --- This is an automatically generated e-ma

Re: Review Request 117957: kcm_fonts: correctly restore default configuration values

2014-07-06 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117957/ --- (Updated Lug. 6, 2014, 10:28 a.m.) Review request for kde-workspace. Ch

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

2014-07-06 Thread Arjun Ak
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118994/ --- (Updated July 6, 2014, 4:16 p.m.) Review request for Dolphin and KDE Base

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

2014-07-06 Thread Thomas Lübking
> On Juli 5, 2014, 11:36 vorm., Arjun Ak wrote: > > dolphin/src/dolphinrecenttabsmenu.cpp, line 102 > > > > > > Is it safe to 'delete' a QObject? shouldnt we be using deleteLater() There's no general rule. Delet

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

2014-07-06 Thread Emmanuel Pescosta
> On July 5, 2014, 1:36 p.m., Arjun Ak wrote: > > dolphin/src/dolphinrecenttabsmenu.cpp, line 102 > > > > > > Is it safe to 'delete' a QObject? shouldnt we be using deleteLater() > > Thomas Lübking wrote: >

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

2014-07-06 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118994/#review61704 --- dolphin/src/dolphinmainwindow.h

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

2014-07-06 Thread Arjun Ak
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118994/ --- (Updated July 6, 2014, 7:28 p.m.) Review request for Dolphin and KDE Base