Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

On July 12, 2014, 2:11 p.m., Marko Käning wrote: > > Other than that it looks ok. Please update the patch though. I have tested the patch on Apple OS X in my kdesrc-build environment for KDE 4.13 branch. Before I did so, I removed the comment from line 316 and also the pair of braces from the

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

> On July 12, 2014, 2:11 p.m., Aleix Pol Gonzalez wrote: > > kio/kfile/kfiledialog.cpp, line 316 > > > > > > I don't know why you did that, but it doesn't look good. > > Marko Käning wrote: > Actually, when

Re: Review Request 119221: Don't rewrite mailto: URLs als mailto://

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119221/ --- (Updated July 14, 2014, 4:47 p.m.) Review request for kdelibs and David F

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/ --- (Updated July 14, 2014, 7:08 p.m.) Review request for KDE Software on Mac

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 14, 2014, 7:10 p.m.) Review request for KDE Software on Mac

Re: 4.13.3 tarballs are available for packagers

El Diumenge, 13 de juliol de 2014, a les 23:52:21, Vishesh Handa va escriure: > On Sat, Jul 12, 2014 at 8:53 PM, Albert Astals Cid wrote: > > El Dissabte, 12 de juliol de 2014, a les 20:11:35, Vishesh Handa va > > > > escriure: > > > On Sat, Jul 12, 2014 at 5:28 PM, Albert Astals Cid > > > > wr

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 14, 2014, 7:59 p.m.) Review request for KDE Software on Mac

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/ --- (Updated July 14, 2014, 8:15 p.m.) Review request for KDE Software on Mac

Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/ --- Review request for kdelibs and David Faure. Repository: kio Description

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

> On Juli 9, 2014, 10:40 vorm., David Faure wrote: > > Looks good, but I'd feel safer if the unittest > > (kio/tests/kurlrequestertest.cpp) was: > > 1) checked for no regressions, and > > 2) extended to cover the case of relative paths, and other things this > > patch is fixing. I need some he

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 14, 2014, 11:26 p.m.) Review request for kdelibs, David Fau

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 14, 2014, 11:49 p.m.) Review request for KDE Software on Ma

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

> On July 12, 2014, 8:49 p.m., David Faure wrote: > > Seems clear enough. > > > > In KF5 the file is in frameworks/kwindowsystem/src/kwindowinfo_mac.cpp > > Marko Käning wrote: > Thanks for the info about KF5! > > Which branch should this be committed to on kdelibs4? Simply on mast

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

> On July 12, 2014, 6:49 p.m., David Faure wrote: > > Seems clear enough. > > > > In KF5 the file is in frameworks/kwindowsystem/src/kwindowinfo_mac.cpp > > Marko Käning wrote: > Thanks for the info about KF5! > > Which branch should this be committed to on kdelibs4? Simply on mast

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119014/#review62361 --- kio/kfile/kurlrequester.cpp

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

> On July 9, 2014, 8:40 a.m., David Faure wrote: > > Looks good, but I'd feel safer if the unittest > > (kio/tests/kurlrequestertest.cpp) was: > > 1) checked for no regressions, and > > 2) extended to cover the case of relative paths, and other things this > > patch is fixing. > > Simon Bachma

Re: 4.13.3 tarballs are available for packagers

On Monday 14 July 2014 21.01.41 Torgny Nyblom wrote: > Sure. First thing tomorrow. baloo is now respun. commit 918ec9d265c315bed4313963c3be58fd748fe26a sha256: c7467bf518dc23e319b581dbc1dff84cd8d0b03516a1d25bde0aa0cd7bbad043 /Regards Torgny > > /Cheers > Torgny > > Original message -