Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-08-02 Thread RJVB Bertin
> On July 27, 2014, 1:17 p.m., Thomas Lübking wrote: > > drkonqi/reportassistantpages_bugzilla.cpp, line 300 > > > > > > this is commented. > > > > if the test is pointless altogether (i do not know. no

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-02 Thread Lukáš Tinkl
On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-08-02 Thread Ben Cooksley
> On July 27, 2014, 11:17 a.m., Thomas Lübking wrote: > > drkonqi/reportassistantpages_bugzilla.cpp, line 300 > > > > > > this is commented. > > > > if the test is pointless altogether (i do not know. no

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-02 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-02 Thread Lukáš Tinkl
On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Re: Review Request 119572: Part: use correct slots for QStatusbar

2014-08-02 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119572/ --- (Updated Aug. 2, 2014, 10:19 vorm.) Review request for kdelibs and Martin

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-02 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-02 Thread Ben Cooksley
On July 28, 2014, 10:17 a.m., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Pushing AppStream data to KDE project's master branches

2014-08-02 Thread Matthias Klumpp
Hi! A while ago I posted some information about how to add AppStream data to KDE projects, in order to make the projects visible in software-centers like Apper, Muon and GNOME-Software. I also compiled AppStream data for most KDE projects from the existing information we have on the web[1]. So far,

Re: Review Request 115727: Deafult for not executing kwalletmanager once a wallet is open

2014-08-02 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115727/ --- (Updated ago. 3, 2014, 12:25 a.m.) Status -- This change has been ma