Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On July 27, 2014, 11:17 a.m., Thomas Lübking wrote: > > drkonqi/reportassistantpages_bugzilla.cpp, line 300 > > > > > > this is commented. > > > > if the test is pointless altogether (i do not know. no

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

> On July 27, 2014, 11:32 a.m., Thomas Lübking wrote: > > kdeui/util/kcrash.cpp, line 316 > > > > > > is libdispatch OSX only or is it also used on FreeBSD? > > > > The question (more to Michael ;-) is w

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

> On July 27, 2014, 11:32 a.m., Thomas Lübking wrote: > > kdeui/util/kcrash.cpp, line 316 > > > > > > is libdispatch OSX only or is it also used on FreeBSD? > > > > The question (more to Michael ;-) is w

Re: Review Request 119593: Ensure there's a plastform window before restoring the window geometry

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119593/#review63728 --- No change here, ie. it doesn't restore the window geometry. -

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/#review63726 --- No change here, ie. it doesn't restore the file dialog geometr

Re: Review Request 119512: Fix saving/loading of file dialog sizes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119512/ --- (Updated Srp. 4, 2014, 12:49 dop.) Status -- This change has been di

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/#review63721 --- Ship it! Makes sense to me. - Aleix Pol Gonzalez On Aug. 3

Re: Review Request 119593: Ensure there's a plastform window before restoring the window geometry

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119593/#review63720 --- Ship it! Good catch! :) I didn't know this was possible. - A

Re: Review Request 119512: Fix saving/loading of file dialog sizes

On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b

Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/ --- Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl

Review Request 119593: Ensure there's a plastform window before restoring the window geometry

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119593/ --- Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl

Re: Pushing AppStream data to KDE project's master branches

2014-08-03 12:20 GMT+02:00 Alex Merry : > On Sunday 03 August 2014 01:41:29 Matthias Klumpp wrote: >> We are speaking of a small bit of XML, which is placed in >> CMAKE_INSTALL_METAINFODIR (/usr/share/appdata) - so this is not a >> change which could break anything (in case you still don't like it,

Re: Pushing AppStream data to KDE project's master branches

On Sunday 03 August 2014 01:41:29 Matthias Klumpp wrote: > We are speaking of a small bit of XML, which is placed in > CMAKE_INSTALL_METAINFODIR (/usr/share/appdata) - so this is not a > change which could break anything (in case you still don't like it, > you can always git-revert, but in that cas