Re: Review Request 119868: KConfig add DirectoryType support

2014-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119868/#review64952 --- We have never needed this until now because we can recognize s

Re: Review Request 119875: add support for Clang Static Analyzer and improve build configuration

2014-08-21 Thread Milian Wolff
> On Aug. 20, 2014, 10:15 p.m., Albert Astals Cid wrote: > > Why is this per repo? This should be in a place all repos get the nice > > stuff without having to do work. > > > > A static Makefile and a configure.sh seem like very bad ideas to me. Why do > > you need those over cmake? > > Mathi

Re: Review Request 119875: add support for Clang Static Analyzer and improve build configuration

2014-08-21 Thread Milian Wolff
> On Aug. 20, 2014, 10:15 p.m., Albert Astals Cid wrote: > > Why is this per repo? This should be in a place all repos get the nice > > stuff without having to do work. > > > > A static Makefile and a configure.sh seem like very bad ideas to me. Why do > > you need those over cmake? > > Mathi

Re: Review Request 119869: KIO: Correctly handle .directory files

2014-08-21 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119869/ --- (Updated Aug. 21, 2014, 1:15 p.m.) Review request for KDE Frameworks, kde

Re: Review Request 119868: KConfig add DirectoryType support

2014-08-21 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119868/ --- (Updated Aug. 21, 2014, 1:15 p.m.) Status -- This change has been di

Re: Review Request 119868: KConfig add DirectoryType support

2014-08-21 Thread Maarten De Meyer
> On Aug. 21, 2014, 7:19 a.m., David Faure wrote: > > We have never needed this until now because we can recognize such files by > > their name... So while I'm not opposed to this, I wonder, why not use if > > (u.fileName() == ".directory") in KDesktopFileActions (RR 119869) -- which > > will

Re: Review Request 119875: add support for Clang Static Analyzer and improve build configuration

2014-08-21 Thread Albert Astals Cid
> On ago. 20, 2014, 10:15 p.m., Albert Astals Cid wrote: > > Why is this per repo? This should be in a place all repos get the nice > > stuff without having to do work. > > > > A static Makefile and a configure.sh seem like very bad ideas to me. Why do > > you need those over cmake? > > Mathi

Re: Review Request 119869: KIO: Correctly handle .directory files

2014-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119869/#review64997 --- Ship it! src/widgets/kdesktopfileactions.cpp

Review Request 119890: [Ark] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2014-08-21 Thread Arjun Ak
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119890/ --- Review request for KDE Base Apps and KDE Utils. Bugs: 338414 http://b

Review Request 119892: [Dolphin] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2014-08-21 Thread Arjun Ak
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119892/ --- Review request for KDE Base Apps and KDE Utils. Bugs: 338414 http://b

Re: Review Request 119892: [Dolphin] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2014-08-21 Thread Arjun Ak
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119892/#review64999 --- lib/konq/konq_operations.cpp

Re: Review Request 119678: add a target named _doc for each project in the tree, to generate developer documention

2014-08-21 Thread Mathieu Tarral
> On août 20, 2014, 8:55 après-midi, Allen Winter wrote: > > We have a standalone program in kde-dev-scripts called kdedoxygen.sh that > > might accomplish the same thing. We also have kdedoxyman.sh (for man > > pages) and kdedoxyqt.sh (for Qt assistant files) > > > > might be worth a look.

Re: Review Request 119678: add a target named _doc for each project in the tree, to generate developer documention

2014-08-21 Thread Mathieu Tarral
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119678/ --- (Updated août 21, 2014, 10:50 après-midi) Status -- This change has