Re: Fwd: PVS-Studio KDE analysis

2014-10-01 Thread Boris Egorov
On 09/29/2014 11:55 PM, Ivan Čukić wrote: > If the report is not separated into components, then I'd guess kde-devel is > the right place for it. Looks like report was not separated, just one huge archive (probably can't be attached to mail due to its size). Svyatoslav (guy who made analysis) tol

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-10-01 Thread René J . V . Bertin
> On Sept. 26, 2014, 7:40 p.m., René J.V. Bertin wrote: > > changing this patch to prevent just the call to > > invalidateBuffer_resizeHelper (and setting isResize=false when that > > function cannot be called) shows something in place of the menu's title > > exactly once. All other times the

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-10-01 Thread Thomas Lübking
> On Sept. 26, 2014, 5:40 nachm., René J.V. Bertin wrote: > > changing this patch to prevent just the call to > > invalidateBuffer_resizeHelper (and setting isResize=false when that > > function cannot be called) shows something in place of the menu's title > > exactly once. All other times th

Re: Review Request 120403: [OS X] adapting KMenu::addTitle to OS X menubar specifics

2014-10-01 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120403/#review67783 --- kdeui/widgets/kmenu.cpp

Re: Fwd: PVS-Studio KDE analysis

2014-10-01 Thread Ben Cooksley
On Tue, Sep 30, 2014 at 7:12 AM, Boris Egorov wrote: > > On 09/29/2014 11:55 PM, Ivan Čukić wrote: >> If the report is not separated into components, then I'd guess kde-devel is >> the right place for it. > Looks like report was not separated, just one huge archive (probably > can't be attached to

Re: Fwd: PVS-Studio KDE analysis

2014-10-01 Thread Christoph Feck
On Wednesday 01 October 2014 23:35:50 Ben Cooksley wrote: > On Tue, Sep 30, 2014 at 7:12 AM, Boris Egorov wrote: > > On 09/29/2014 11:55 PM, Ivan Čukić wrote: > >> If the report is not separated into components, then I'd guess > >> kde-devel is the right place for it. > > > > Looks like report w