Review Request 120528: [OS X]: respect icon visibility preference in system tray menus

2014-10-08 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120528/ --- Review request for KDE Software on Mac OS X and Qt KDE. Repository: qt

Review Request 120529: [OS X] avoid crash when calling invalidateBuffer_resizeHelper on parentless widget

2014-10-08 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120529/ --- Review request for KDE Software on Mac OS X and Qt KDE. Repository: qt

Re: Review Request 120528: [OS X]: respect icon visibility preference in system tray menus

2014-10-08 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120528/#review68076 --- To get changes into Qt, you directly create the review

Re: Review Request 120528: [OS X]: respect icon visibility preference in system tray menus

2014-10-08 Thread Christoph Feck
On Oct. 8, 2014, 11:47 a.m., Christoph Feck wrote: To get changes into Qt, you directly create the review requests on the qt-project.org site: http://qt-project.org/wiki/Gerrit-Introduction Ignore that comment... :P - Christoph

Re: Review Request 120528: [OS X]: respect icon visibility preference in system tray menus

2014-10-08 Thread René J . V . Bertin
On Oct. 8, 2014, 1:47 p.m., Christoph Feck wrote: To get changes into Qt, you directly create the review requests on the qt-project.org site: http://qt-project.org/wiki/Gerrit-Introduction Christoph Feck wrote: Ignore that comment... :P Ok. Or rather, I'll jump on the occasion to

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

2014-10-08 Thread Aleix Pol
On Tue, Oct 7, 2014 at 3:13 PM, Thomas Pfeiffer thomas.pfeif...@kde.org wrote: On Sunday 05 October 2014 20:30:33 Albert Astals Cid wrote: The reasoning is that this way they will be released together with Plasma Workspace. I don't see that anyone can have a problem with

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

2014-10-08 Thread Albert Astals Cid
El Dimecres, 8 d'octubre de 2014, a les 21:02:32, Aleix Pol va escriure: On Tue, Oct 7, 2014 at 3:13 PM, Thomas Pfeiffer thomas.pfeif...@kde.org wrote: On Sunday 05 October 2014 20:30:33 Albert Astals Cid wrote: The reasoning is that this way they will be released together with

Re: kompare, libkomparediff2 and KDE Applications 14.12

2014-10-08 Thread Aleix Pol
On Tue, Oct 7, 2014 at 11:59 PM, Jeremy Whiting jpwhit...@kde.org wrote: Kevin, Others, Libkomparediff2 has been ported to kf5 for quite some time, kdevelop or kdevplatform frameworks based code (not sure if it's master or frameworks branches) uses it and it seems to work ok there. I wonder

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

2014-10-08 Thread Aleix Pol
On Wed, Oct 8, 2014 at 9:59 PM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 8 d'octubre de 2014, a les 21:02:32, Aleix Pol va escriure: On Tue, Oct 7, 2014 at 3:13 PM, Thomas Pfeiffer thomas.pfeif...@kde.org wrote: On Sunday 05 October 2014 20:30:33 Albert Astals Cid wrote:

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

2014-10-08 Thread Albert Astals Cid
El Dimecres, 8 d'octubre de 2014, a les 22:23:44, Aleix Pol va escriure: On Wed, Oct 8, 2014 at 9:59 PM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 8 d'octubre de 2014, a les 21:02:32, Aleix Pol va escriure: On Tue, Oct 7, 2014 at 3:13 PM, Thomas Pfeiffer thomas.pfeif...@kde.org

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

2014-10-08 Thread Luigi Toscano
Aleix Pol ha scritto: On Wed, Oct 8, 2014 at 9:59 PM, Albert Astals Cid aa...@kde.org mailto:aa...@kde.org wrote: El Dimecres, 8 d'octubre de 2014, a les 21:02:32, Aleix Pol va escriure: On Tue, Oct 7, 2014 at 3:13 PM, Thomas Pfeiffer thomas.pfeif...@kde.org

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120535/ --- (Updated Oct. 8, 2014, 3:20 p.m.) Review request for KDE Frameworks,

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120535/#review68095 --- According to

Re: kompare, libkomparediff2 and KDE Applications 14.12

2014-10-08 Thread Kevin Kofler
Hi Aleix, hi everyone, On Wednesday 08 October 2014 at 22:08:58, Aleix Pol wrote: I think we're aiming for 2nd quarter of 2015, it depends a lot on when we manage to have a sprint I'd say. Things are going forward, but there's still work to be done. So that will likely be after the next

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
On Oct. 8, 2014, 3:22 p.m., Albert Astals Cid wrote: According to https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ changing the const/volatile qualifiers of the function is BIC Now the thing is if we allow BIC changes in frameworks like attica or not is for

Re: kompare, libkomparediff2 and KDE Applications 14.12

2014-10-08 Thread Jeremy Whiting
K, sounds like we've agreed then, libkomparediff2 frameworks branch wont merge to master until some time after 14.12 is tagged and such. If I find a few minutes I'll take a look at improving the api and such as Aleix noted. BR, Jeremy On Wed, Oct 8, 2014 at 3:25 PM, Kevin Kofler

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Aleix Pol Gonzalez
On Oct. 8, 2014, 9:22 p.m., Albert Astals Cid wrote: According to https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ changing the const/volatile qualifiers of the function is BIC Now the thing is if we allow BIC changes in frameworks like attica or not is for

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
On Oct. 8, 2014, 3:22 p.m., Albert Astals Cid wrote: According to https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ changing the const/volatile qualifiers of the function is BIC Now the thing is if we allow BIC changes in frameworks like attica or not is for

Re: kompare, libkomparediff2 and KDE Applications 14.12

2014-10-08 Thread Aleix Pol
On Wed, Oct 8, 2014 at 11:48 PM, Jeremy Whiting jpwhit...@kde.org wrote: K, sounds like we've agreed then, libkomparediff2 frameworks branch wont merge to master until some time after 14.12 is tagged and such. If I find a few minutes I'll take a look at improving the api and such as Aleix

Re: kompare, libkomparediff2 and KDE Applications 14.12

2014-10-08 Thread Albert Astals Cid
El Dijous, 9 d'octubre de 2014, a les 00:12:03, Aleix Pol va escriure: On Wed, Oct 8, 2014 at 11:48 PM, Jeremy Whiting jpwhit...@kde.org wrote: K, sounds like we've agreed then, libkomparediff2 frameworks branch wont merge to master until some time after 14.12 is tagged and such. If I

Re: kompare, libkomparediff2 and KDE Applications 14.12

2014-10-08 Thread Jeremy Whiting
Aleix, Yes, master is what will be released with KDE Applications 14.12 so it needs to stay qt4 based for now since kompare itself will be in this upcoming release. BR, Jeremy On Wed, Oct 8, 2014 at 4:14 PM, Kevin Kofler kevin.kof...@chello.at wrote: On Thursday 09 October 2014 at 00:12:03,

kdelibs coding style.

2014-10-08 Thread Jeremy Whiting
Hey all, In updating some frameworks I took a look at the kdelibs coding style (Is there a frameworks coding style, if not maybe it should be created?) and especially the Qt Includes section seems a bit backwards from what I see in actual code in frameworks.

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-08 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/ --- (Updated Oct. 9, 2014, 12:06 a.m.) Review request for KDE Software on

Re: kompare, libkomparediff2 and KDE Applications 14.12

2014-10-08 Thread Aleix Pol
On Thu, Oct 9, 2014 at 12:13 AM, Albert Astals Cid aa...@kde.org wrote: El Dijous, 9 d'octubre de 2014, a les 00:12:03, Aleix Pol va escriure: On Wed, Oct 8, 2014 at 11:48 PM, Jeremy Whiting jpwhit...@kde.org wrote: K, sounds like we've agreed then, libkomparediff2 frameworks branch

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-08 Thread Ian Wadham
On Oct. 7, 2014, 1:13 p.m., Thomas Lübking wrote: drkonqi/bugzillalib.cpp, line 81 https://git.reviewboard.kde.org/r/120431/diff/4/?file=316623#file316623line81 The patch largely consists of hand-crafted version handling. replacing this by int version =

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-08 Thread Ian Wadham
On Oct. 7, 2014, 1:13 p.m., Thomas Lübking wrote: My 2¢ Bugzilla will require an update anyway and that means at some point it'll be (then silently) broken in KDE SC4 again and somebody has to step up and fix it with another patch. In the meantime we've diverging codebases for KDE 4