Re: Review Request 120543: Update FindPostgreSQL.cmake

2014-10-09 Thread Jaroslaw Staniek
On 10 October 2014 08:05, Rolf Eike Beer wrote: >> Update FindPostgreSQL.cmake to make is useful. Based on cmake's (3.x) one >> but further improved PostgreSQL_TYPE_INCLUDE_DIR lookup. The fix comes from >> libpredicate (master). > > I see no upstream bug report for this. Would a bug report for C

Re: Review Request 120543: Update FindPostgreSQL.cmake

2014-10-09 Thread Rolf Eike Beer
> Update FindPostgreSQL.cmake to make is useful. Based on cmake's (3.x) one > but further improved PostgreSQL_TYPE_INCLUDE_DIR lookup. The fix comes from > libpredicate (master). I see no upstream bug report for this. Eike signature.asc Description: This is a digitally signed message part.

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-09 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/ --- (Updated Oct. 9, 2014, 11:30 p.m.) Status -- This change has been ma

Review Request 120543: Update FindPostgreSQL.cmake

2014-10-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120543/ --- Review request for kdelibs and Alexander Neundorf. Repository: kdelibs

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-09 Thread Ian Wadham
> On Oct. 7, 2014, 1:13 p.m., Thomas Lübking wrote: > > My 2¢ > > Bugzilla will require an update anyway and that means at some point it'll > > be (then "silently") broken in KDE SC4 again and somebody has to step up > > and fix it with another patch. > > In the meantime we've diverging codebas

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review68187 --- Ship it! Ship It! - Albert Astals Cid On oct. 9, 2014, 12:

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-09 Thread Albert Astals Cid
> On oct. 9, 2014, 8:06 p.m., Ian Wadham wrote: > > A simplified patch for Dr Konqi went in for review about 20 hours ago. > > There are now about 4 hours till the KDE 4.14.2 deadline and there has been > > no feedback re the new patch, but it does follow previous reviewers' > > suggestions. >

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-09 Thread Albert Astals Cid
> On oct. 7, 2014, 1:13 p.m., Thomas Lübking wrote: > > My 2¢ > > Bugzilla will require an update anyway and that means at some point it'll > > be (then "silently") broken in KDE SC4 again and somebody has to step up > > and fix it with another patch. > > In the meantime we've diverging codebas

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-09 Thread Thomas Lübking
> On Okt. 9, 2014, 8:06 nachm., Ian Wadham wrote: > > A simplified patch for Dr Konqi went in for review about 20 hours ago. > > There are now about 4 hours till the KDE 4.14.2 deadline and there has been > > no feedback re the new patch, but it does follow previous reviewers' > > suggestions.

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-09 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120431/#review68183 --- A simplified patch for Dr Konqi went in for review about 20 ho

Re: kdelibs coding style.

2014-10-09 Thread Luigi Toscano
Jeremy Whiting ha scritto: > Are we suggesting the opposite for > that section at least? Should we put together a Frameworks coding > policy (since kdelibs coding policy is what is documented there, but > frameworks aren't kdelibs) or update that page to what we suggest for > frameworks coding poli

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-09 Thread Sebastian Kügler
> On Oct. 8, 2014, 9:22 p.m., Albert Astals Cid wrote: > > According to > > https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ > > "changing the const/volatile qualifiers of the function" is BIC > > > > Now the thing is if we allow BIC changes in frameworks like attica or n