Re: Review Request 120376: drKonqi Fix Bug 337742 - Unable to send report: error code 410 from Bugzilla

> On Sept. 26, 2014, 11:54 a.m., Ian Wadham wrote: > > Hi Frédéric, > > > > As announced on KDE Core devel, in > > http://lists.kde.org/?l=kde-core-devel&m=141016488132293&w=2 about 3 weeks > > ago, I also am working on Dr Konqi. > > > > I am about to publish a general patch, which is aimed a

Re: Porting KUrl::prettyUrl: please do not reintroduce CVE-2013-2074!

I personally think QUrl should remove the password by default when converting to string and force caller of the API to explicitly request the inclusion of the password say by changing the modifier option to a QUrl::IncludePassword. It is better to be safer out of the box. On Thu, Oct 16, 2014 at 8

Re: Review Request 120554: Initial frameworks port of kompare

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/ --- (Updated Oct. 17, 2014, 2:05 a.m.) Status -- This change has been ma

Re: Review Request 120554: Initial frameworks port of kompare

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/#review68588 --- Ship it! Looks like all the issues are resolved now (except t

Re: Review Request 120554: Initial frameworks port of kompare

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/ --- (Updated Oct. 16, 2014, 7:53 p.m.) Review request for kdelibs and Kevin K

Re: Review Request 120554: Initial frameworks port of kompare

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/ --- (Updated Oct. 16, 2014, 7:48 p.m.) Review request for kdelibs and Kevin K

Re: Review Request 120554: Initial frameworks port of kompare

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/#review68587 --- Oh, I missed this one: > The QFileDialog it uses wasn't showin

Re: Review Request 120554: Initial frameworks port of kompare

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/ --- (Updated Oct. 16, 2014, 7:45 p.m.) Review request for kdelibs and Kevin K

Porting KUrl::prettyUrl: please do not reintroduce CVE-2013-2074!

Hi, just a small public service announcement: The correct replacement for: url.prettyUrl() in Qt 5 is NOT: url.toString() // BAD! but: url.toString(QUrl::RemovePassword) The old KUrl::prettyUrl() always removed passwords. You DON'T want to show passwords in user output: http://cve.mitre.org/cgi-

Re: Review Request 120554: Initial frameworks port of kompare

> On Okt. 16, 2014, 10:47 nachm., Kevin Kofler wrote: > > komparepart/kompare_part.cpp, line 295 > > > > > > This should pass at least QUrl::RemoveUserInfo to toString(), we don't > > want to echo passwords in e

Re: Review Request 120554: Initial frameworks port of kompare

> On Okt. 16, 2014, 10:47 nachm., Kevin Kofler wrote: > > komparepart/kompare_part.cpp, line 295 > > > > > > This should pass at least QUrl::RemoveUserInfo to toString(), we don't > > want to echo passwords in e

Re: Review Request 120554: Initial frameworks port of kompare

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/#review68582 --- See my point by point review below. Once all the issues are ad

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/ --- (Updated Oct. 17, 2014, 12:35 a.m.) Review request for KDE Software on Ma

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Oct. 14, 2014, 11:13 p.m., David Faure wrote: > > kioslave/trash/trashimpl.cpp, line 854 > > > > > > deleteEmptyTrashInfraStructure is implemented on all OSes, but only > > called on Mac, which seems a bit

Re: Using Gerrit for code review in KDE

Jan Kundrát wrote: > A random data point -- I asked a 3rd-party contributor to send a patch to > Trojita through Gerrit earlier today. He accomplished that goal so fast > that I asked him for an estimate on how much time it took. The answer was > 15 minutes, including reading the docs and setting u

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Oct. 14, 2014, 11:13 p.m., David Faure wrote: > > kioslave/trash/trashimpl.cpp, line 170 > > > > > > Shouldn't this return false like the other blocks? > > > > And then I would swap the if and else

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On Oct. 15, 2014, 10:07 p.m., Thomas Lübking wrote: > > Please check https://techbase.kde.org/Policies/Kdelibs_Coding_Style > > René J.V. Bertin wrote: > Sure, and guess what I noticed first ;) > > ``` > Nobody is forced to use this style, but to have consistent formatting of

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Okt. 14, 2014, 9:13 nachm., David Faure wrote: > > kioslave/trash/trashimpl.cpp, line 170 > > > > > > Shouldn't this return false like the other blocks? > > > > And then I would swap the if and else

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Oct. 14, 2014, 9:35 p.m., Thomas Lübking wrote: > > kioslave/trash/trashimpl.cpp, line 362 > > > > > > This can only make sense when > > a) init() created $TRASH/KDE.trash > > b) deleteEmptyTrashInfr

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Oct. 14, 2014, 11:13 p.m., David Faure wrote: > > kioslave/trash/trashimpl.cpp, line 170 > > > > > > Shouldn't this return false like the other blocks? > > > > And then I would swap the if and else

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On Okt. 15, 2014, 8:07 nachm., Thomas Lübking wrote: > > Please check https://techbase.kde.org/Policies/Kdelibs_Coding_Style > > René J.V. Bertin wrote: > Sure, and guess what I noticed first ;) > > ``` > Nobody is forced to use this style, but to have consistent formatting of

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Okt. 14, 2014, 9:13 nachm., David Faure wrote: > > kioslave/trash/trashimpl.cpp, line 170 > > > > > > Shouldn't this return false like the other blocks? > > > > And then I would swap the if and else

Re: kdepimlibs Coverity Scan Report, Oct 14 2014

Yes, Web interface is a pleasure to use and learn about dysfunctions. I recommend highly to generalize Coverity SCAN for whole KDE. It's really good static code analyzer Sure it give false positive but mostly all are true, and sometime very instructive about code writing from contributors. Compar

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Oct. 14, 2014, 11:13 p.m., David Faure wrote: > > kioslave/trash/trashimpl.cpp, line 1043 > > > > > > such a debug statement is more useful if it prints out the input to the > > method, i.e. "topdir". > >

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

> On Oct. 14, 2014, 11:13 p.m., David Faure wrote: > > kioslave/trash/trashimpl.cpp, line 170 > > > > > > Shouldn't this return false like the other blocks? > > > > And then I would swap the if and else

Re: kdepimlibs Coverity Scan Report, Oct 14 2014

On Thu, October 16, 2014 2:06 pm, Gilles Caulier wrote: > 2014-10-16 12:29 GMT+02:00 Ben Cooksley : >> On Thu, Oct 16, 2014 at 8:53 PM, Gilles Caulier >> wrote: >>> Allen, >> >> Hi Gilles, >> >>> >>> Just a workflow question : why to export Coverity report to CSV where >>> you can send automatical

Re: Review Request 120376: drKonqi Fix Bug 337742 - Unable to send report: error code 410 from Bugzilla

> On sep. 26, 2014, 11:54 matin, Ian Wadham wrote: > > Hi Frédéric, > > > > As announced on KDE Core devel, in > > http://lists.kde.org/?l=kde-core-devel&m=141016488132293&w=2 about 3 weeks > > ago, I also am working on Dr Konqi. > > > > I am about to publish a general patch, which is aimed a

Re: kdepimlibs Coverity Scan Report, Oct 14 2014

2014-10-16 12:29 GMT+02:00 Ben Cooksley : > On Thu, Oct 16, 2014 at 8:53 PM, Gilles Caulier > wrote: >> Allen, > > Hi Gilles, > >> >> Just a workflow question : why to export Coverity report to CSV where >> you can send automatically a mail to devel mailing list when scan is >> complete, with a a

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On Oct. 15, 2014, 10:07 p.m., Thomas Lübking wrote: > > Please check https://techbase.kde.org/Policies/Kdelibs_Coding_Style Sure, and guess what I noticed first ;) ``` Nobody is forced to use this style, but to have consistent formatting of the source code files it is recommended to make use

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120202/ --- (Updated Oct. 16, 2014, 1:26 p.m.) Review request for KDE Software on Mac

Re: kdepimlibs Coverity Scan Report, Oct 14 2014

On Thu, Oct 16, 2014 at 8:53 PM, Gilles Caulier wrote: > Allen, Hi Gilles, > > Just a workflow question : why to export Coverity report to CSV where > you can send automatically a mail to devel mailing list when scan is > complete, with a a list of new defect found in code. > > I use Coverity si

Fwd: kdepimlibs Coverity Scan Report, Oct 14 2014

Allen, Just a workflow question : why to export Coverity report to CSV where you can send automatically a mail to devel mailing list when scan is complete, with a a list of new defect found in code. I use Coverity since more than one year with whole digiKam code, and we have already fixed more th

Re: [Kde-pim] [UPDATE] kdepimlibs Coverity Scan Report, Oct 14 2014

On Tuesday 14 October 2014 17.53:06 Allen Winter wrote: > Attached ? -- Georg C. F. Greve Chief Executive Officer Kolab Systems AGMake it your Kolab @ http://mykolab.com Zürich, Switzerland Swiss Secure Collaboration as a Service e: g

kdepimlibs Coverity Scan Report, Oct 14 2014

Howdy, Attached is the Coverity Scan report for kdepimlibs 4.14 as of today. You might feel like fixing some of the issues. Let me know if you find false positives or stuff we can ignore (like in test programs). CID Type Impact Category File Function 1245732 Uninitialized scalar variable High