Re: [Kde-pim] Problems with infrastructure

2014-12-14 Thread Aleix Pol
On Mon, Dec 15, 2014 at 2:58 AM, Kevin Kofler wrote: > Albert Astals Cid wrote: >> It also puts the discussion about a possible switch to gerrit in a weird >> situaion since we either all switch and have uniformity or we don't and >> then we end up with reviewborad+gerrit :/ > > Or we just stop th

Re: [Kde-pim] Problems with infrastructure

2014-12-14 Thread Kevin Kofler
Albert Astals Cid wrote: > It also puts the discussion about a possible switch to gerrit in a weird > situaion since we either all switch and have uniformity or we don't and > then we end up with reviewborad+gerrit :/ Or we just stop the Gerrit experiment in the core KDE projects as a failure (it

Re: Review Request 121511: Fix to error in kfilemetainfo.cpp so it builds again

2014-12-14 Thread Paul Manners
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121511/ --- (Updated Dec. 14, 2014, 10:31 p.m.) Status -- This change has been m

Re: Review Request 121511: Fix to error in kfilemetainfo.cpp so it builds again

2014-12-14 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121511/#review72011 --- Ship it! If it compiles, shit it :D You could most probably

Re: Review Request 121511: Fix to error in kfilemetainfo.cpp so it builds again

2014-12-14 Thread Paul Manners
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121511/ --- (Updated Dec. 14, 2014, 10:03 p.m.) Review request for kdelibs. Changes

Re: Review Request 120761: Added support for NFSv3, major refactoring, fixed bugs

2014-12-14 Thread Albert Astals Cid
> On nov. 16, 2014, 2:24 p.m., Christoph Feck wrote: > > Albert, this is a backport of https://git.reviewboard.kde.org/r/120343/ > > > > David Faure already approved a backport to KDE 4 there, but was not sure if > > release team is okey with the backport. > > Albert Astals Cid wrote: > I'

Re: Review Request 121511: Fix to allow kfilemetainfo.h and kfilemetainfo.cpp to build

2014-12-14 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121511/#review71986 --- Don't change public headers. It's just that the no_strigi par

Review Request 121511: Fix to allow kfilemetainfo.h and kfilemetainfo.cpp to build

2014-12-14 Thread Paul Manners
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121511/ --- Review request for kdelibs. Repository: kdelibs Description --- Ap

Re: Ksshaskpass ?

2014-12-14 Thread Thomas Lübking
On Sonntag, 14. Dezember 2014 13:52:51 CEST, Jeremy Whiting wrote: Martin, Thomas, Is the implementation of InputGuard at https://github.com/luebking/qarma/commit/b568dd14d6e1f661791c4d67245c614f1dc1986f with https://github.com/luebking/qarma/commit/3199c0a9810ed8f792b415e890425be8f2e8034a compl

Re: Re: Ksshaskpass ?

2014-12-14 Thread Jeremy Whiting
Martin, Thomas, Is the implementation of InputGuard at https://github.com/luebking/qarma/commit/b568dd14d6e1f661791c4d67245c614f1dc1986f with https://github.com/luebking/qarma/commit/3199c0a9810ed8f792b415e890425be8f2e8034a complete then? should we copy that into kwidgetsaddons and use it in kpass