Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-19 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/ --- (Updated Jan. 19, 2015, 9:37 p.m.) Review request for KDE Base Apps, Domi

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-19 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/ --- (Updated Jan. 19, 2015, 9:33 p.m.) Review request for KDE Base Apps and J

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-19 Thread Gregor Mi
> On Jan. 19, 2015, 6:24 p.m., Aleix Pol Gonzalez wrote: > > processcore/process.h, line 103 > > > > > > Maybe you want to prefix the attribute variables with m_ then? Thanks for the hint. I will move this membe

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/#review74353 --- processcore/process.h

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-19 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/ --- (Updated Jan. 19, 2015, 6:17 p.m.) Review request for KDE Base Apps, Domi