Re: Review Request 122987: Allow user to specify path to myspell dictionary files

> On March 17, 2015, 6:05 p.m., Christophe Giboudeaux wrote: > > src/plugins/hunspell/CMakeLists.txt, line 9 > > > > > > endif() > > Eugene Shalygin wrote: > Ping? He means you shouldn't put anything inside e

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/#review78586 --- This doesn't let the user change the path but the distributor,

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

> On Березень 17, 2015, 6:05 після полудня, Christophe Giboudeaux wrote: > > src/plugins/hunspell/CMakeLists.txt, line 9 > > > > > > endif() Ping? - Eugene -

Re: Moving KDots to KDE Review

Here is the patch. Checked with clang 3.5.0, qt 4.8.6, KDE Development Platform 4.14.6 Regards, Minh On 6 April 2015 at 16:20, Minh Ngo wrote: > Hi, > > Yeah, there was some problem with clang, but unfortunately I have fixed > them after porting to KF5. I will try to prepare a patch. > > Kind

Re: Strigi usage in KF5 world

El Diumenge, 5 d'abril de 2015, a les 20:47:03, šumski va escriure: > Hi all, > > In review 120393 [1] it was suggested to remove all code that hasn't > compiled at least since 5.0.0. Nepomuk parts won't work even if the #if's > would be correctly adjusted, as there isn't Qt5 based soprano, but st

Re: Moving KDots to KDE Review

Hi, Yeah, there was some problem with clang, but unfortunately I have fixed them after porting to KF5. I will try to prepare a patch. Kind Regards, Minh On 6 April 2015 at 15:59, Ian Wadham wrote: > Hi MInh, > > On 06/04/2015, at 12:37 AM, Minh Ngo wrote: > > > Thanks, but it should not be.

Re: Moving KDots to KDE Review

Hi MInh, On 06/04/2015, at 12:37 AM, Minh Ngo wrote: > > Thanks, but it should not be. You seem to have skipped > > https://techbase.kde.org/Policies/Application_Lifecycle#Stage_1:_The_start > > … :-) > > i.e. I do not think anybody in the KDE Games group has seen your code or, > > more > > im

Re: Moving KDots to KDE Review

On Mon, Apr 6, 2015 at 9:45 PM, Minh Ngo wrote: > Hi, Hi Minh, > >> - do you plan other kdelibs4-based versions? > > No, I don't. > >> - related to the previous question: can you please fix the i18n branches >> from > projects.kde.org? If the current master is KF5-based, as it seems, and you > d

Re: Moving KDots to KDE Review

Hi, > - do you plan other kdelibs4-based versions? No, I don't. > - related to the previous question: can you please fix the i18n branches from projects.kde.org? If the current master is KF5-based, as it seems, and you don't plan other kdelibs4 versions, please set trunk_kf5 to master and the ot

Re: Syncing ECM release number with KF5

On 04/04/15 19:44, David Faure wrote: > On Saturday 28 March 2015 05:49:01 Michael Palimaka wrote: >> On 28/03/15 03:48, Alex Merry wrote: >>> On Wednesday 25 March 2015 22:35:24 Stephen Kelly wrote: Hello, ECM release numbers are in sync with KF5 release numbers, except for the

Strigi usage in KF5 world

Hi all, In review 120393 [1] it was suggested to remove all code that hasn't compiled at least since 5.0.0. Nepomuk parts won't work even if the #if's would be correctly adjusted, as there isn't Qt5 based soprano, but strigi ones in theory should, if the find_package call would be restored. The

Re: Moving KDots to KDE Review

Hi, > Thanks, but it should not be. You seem to have skipped > https://techbase.kde.org/Policies/Application_Lifecycle#Stage_1:_The_start … :-) > i.e. I do not think anybody in the KDE Games group has seen your code or,