Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Patrick Eigensatz
> On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 91 > > > > > > I'm not sure if I can access "Klipper" from here. If I have a look at > > how this is done at other option

Re: Porting to KF5 - kimageio question

2015-05-17 Thread Martin Koller
On Sunday 10 May 2015 19:39:07 Alex Merry wrote: > On Saturday 09 May 2015 22:54:49 Martin Koller wrote: > > I'm working on porting kolourpaint to kf5. > > Now I find the following: > > KDELIBS4SUPPORT_DEPRECATED_EXPORT QStringList typeForMime(const QString > > &mimeType); > > > > The comment says

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Martin Gräßlin
> On May 17, 2015, 8:22 p.m., Martin Gräßlin wrote: > > klipper/generalconfig.ui, lines 36-45 > > > > > > unrelated to the discussion about how to call the entries: I would call > > the config option differently

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Martin Gräßlin
> On May 16, 2015, 11:37 p.m., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 91 > > > > > > I'm not sure if I can access "Klipper" from here. If I have a look at > > how this is done at other options

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Patrick Eigensatz
> On Mai 17, 2015, 6:22 nachm., Martin Gräßlin wrote: > > klipper/generalconfig.ui, lines 36-45 > > > > > > unrelated to the discussion about how to call the entries: I would call > > the config option differentl

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Martin Gräßlin
> On May 17, 2015, 8:22 p.m., Martin Gräßlin wrote: > > klipper/generalconfig.ui, lines 36-45 > > > > > > unrelated to the discussion about how to call the entries: I would call > > the config option differently

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Patrick Eigensatz
> On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 91 > > > > > > I'm not sure if I can access "Klipper" from here. If I have a look at > > how this is done at other option

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Thomas Pfeiffer
> On May 16, 2015, 9:37 p.m., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 91 > > > > > > I'm not sure if I can access "Klipper" from here. If I have a look at > > how this is done at other options

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Patrick Eigensatz
> On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 91 > > > > > > I'm not sure if I can access "Klipper" from here. If I have a look at > > how this is done at other option

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Christoph Feck
> On May 16, 2015, 9:37 p.m., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 91 > > > > > > I'm not sure if I can access "Klipper" from here. If I have a look at > > how this is done at other options

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Thomas Pfeiffer
> On May 16, 2015, 9:37 p.m., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 91 > > > > > > I'm not sure if I can access "Klipper" from here. If I have a look at > > how this is done at other options

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Kai Uwe Broulik
> On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 91 > > > > > > I'm not sure if I can access "Klipper" from here. If I have a look at > > how this is done at other option

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Christoph Feck
> On May 16, 2015, 9:37 p.m., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 91 > > > > > > I'm not sure if I can access "Klipper" from here. If I have a look at > > how this is done at other options

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Patrick Eigensatz
> On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 91 > > > > > > I'm not sure if I can access "Klipper" from here. If I have a look at > > how this is done at other option

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Patrick Eigensatz
> On Mai 17, 2015, 6:22 nachm., Martin Gräßlin wrote: > > klipper/generalconfig.ui, lines 36-45 > > > > > > unrelated to the discussion about how to call the entries: I would call > > the config option differentl

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123806/#review80532 --- klipper/generalconfig.ui (lines 36 - 45)

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Thomas Pfeiffer
> On May 16, 2015, 4:37 p.m., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't c

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Thomas Lübking
> On Mai 16, 2015, 4:37 nachm., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Thomas Pfeiffer
> On May 16, 2015, 4:37 p.m., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't c

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Patrick Eigensatz
> On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 91 > > > > > > I'm not sure if I can access "Klipper" from here. If I have a look at > > how this is done at other option

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Thomas Lübking
> On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 91 > > > > > > I'm not sure if I can access "Klipper" from here. If I have a look at > > how this is done at other option

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Thomas Lübking
> On Mai 16, 2015, 4:37 nachm., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Patrick Eigensatz
> On Mai 16, 2015, 4:37 nachm., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-17 Thread Thomas Lübking
> On Mai 16, 2015, 4:37 nachm., Christoph Feck wrote: > > klipper/klipper.kcfg, line 32 > > > > > > It would be immensely useful, if Klipper also showed leading/trailing > > whitespace, i.e. for items that aren't