Re: Review Request 125010: konq-plugins: port kttsd plugin to QtSpeech

2015-09-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125010/#review84941 --- Ship it! Ah, sorry. I skipped reviewing that one because I wa

Re: Porting to frameworks 2: libkcompactdisc

2015-09-07 Thread Alexander Potashev
2015-09-04 14:59 GMT+03:00 Friedrich W. H. Kossebau : > Am Freitag, 4. September 2015, 02:28:49 schrieb Alexander Potashev: >> I think the new fancy library naming scheme is >> "libKF5Xxx.so.SOVERSION", regardless of it being part of KF5 or not. >> Thus libKF5CompactDisc.so.5. > > If that really is

Re: Review Request 125081: Fix build on OS X

2015-09-07 Thread Albert Astals Cid
> On set. 6, 2015, 10:52 p.m., Albert Astals Cid wrote: > > include config-kwindowsystem.h and use KWINDOWSYSTEM_HAVE_X11? > > Samuel Gaist wrote: > And move all X11 related includes together ? I'd only put netw.h there since it's the one that clearly comes from kwindowsystem having x11 su

Re: Bringing back rsibreak from unmaintained

2015-09-07 Thread Albert Astals Cid
El Diumenge, 30 d'agost de 2015, a les 18:50:12, Jeremy Whiting va escriure: > Just rebuilt it. It seems to run ok. The config dialog does look a lot > cleaner. nice work. I'll report back if I hit any issues as it runs > and such. Since there's been no complains i'll ask for it to be moved to ext

Re: Review Request 125068: Make Format Painter work in KRichTextWidget

2015-09-07 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125068/#review84970 --- Ship it! Ship It! - Albert Astals Cid On set. 5, 2015, 11:

Re: Review Request 125068: Make Format Painter work in KRichTextWidget

2015-09-07 Thread Luigi Toscano
> On Set. 7, 2015, 10:12 p.m., Albert Astals Cid wrote: > > Ship It! Is the fix relevant for to the ktextwidgets framework as well? - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/

Review Request 125097: Icons for hiding/unhiding files

2015-09-07 Thread Roman Gilg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125097/ --- Review request for kde-workspace and Emmanuel Pescosta. Repository: breez

Re: Review Request 125081: Fix build on OS X

2015-09-07 Thread Samuel Gaist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125081/ --- (Updated Sept. 7, 2015, 10:08 p.m.) Review request for KDE Base Apps and

Re: Review Request 125081: Fix build on OS X

2015-09-07 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125081/#review84980 --- Ship it! give mgraesslin one day or so and if no answer commi

Re: Review Request 125081: Fix build on OS X

2015-09-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125081/#review84982 --- konqueror/src/konqmainwindow.cpp (line 150)

Re: Review Request 125081: Fix build on OS X

2015-09-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125081/#review84983 --- Ideally the usage of netwm should be removed. NETWM is very lo