Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote: > > src/kpackage/packageloader.cpp, line 190 > > > > > > What does the category have to do with this? We should only be going by > > the id (the plugin name)

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote: > > src/kpackage/packageloader.cpp, line 190 > > > > > > What does the category have to do with this? We should only be going by > > the id (the plugin name)

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote: > > src/kpackage/packageloader.cpp, line 187 > > > > > > This doesn't actually add anything. A better name would IMO be: > > alreadyListed() or something alo

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote: > > Wouldn't it be way easier to simply check if the plugin is already in lst? > > > > Your approach looks very complex for just that... O(n) vs. O(n^2) - Andreas --- This is an aut

Review Request 126660: Avoid finding the same package multiple times from different paths.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126660/ --- Review request for kde-workspace, KDE Frameworks and kdelibs. Repository:

Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126659/ --- (Updated Jan. 7, 2016, 12:46 p.m.) Status -- This change has been ma

Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126659/#review90750 --- Ship it! Ship It! - David Faure On Jan. 7, 2016, 12:23 p.m

Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

> On Jan. 7, 2016, 11:15 a.m., David Faure wrote: > > src/ioslaves/ftp/ftp.cpp, line 1775 > > > > > > The porting bug is here. In kdelibs4 tmptr was initialized to the > > current date, and used below. > >

Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126659/ --- Review request for KDE Frameworks, kdelibs and David Faure. Bugs: 354597

Re: KF5 Porting Notes

On Wed, Jan 6, 2016 at 11:15 PM, Albert Astals Cid wrote: > El Wednesday 06 January 2016, a les 14:56:48, Martin Koller va escriure: >> In the section about KApplication -> QApplication, I find: >> >> Make sure to: >> Call QCoreApplication::setApplicationName() and others ... >> >> It seems this i