Re: ghostwriter is ready for your review

2022-10-17 Thread Albert Astals Cid
El diumenge, 16 d’octubre de 2022, a les 5:05:40 (CEST), Megan va escriure: > Hi Albert, > > > If you're going to change something as core to an app as the i18n system I > > wouldn't say we're done for review stage yet. Or maybe you don't need to > > change it? > > Carl said it should be enough t

Re: kio-admin in kdereview

2022-10-17 Thread Albert Astals Cid
El dimecres, 12 d’octubre de 2022, a les 10:40:45 (CEST), Harald Sitter va escriure: > Hola > > kio-admin implements an admin worker that gives root level access to > the file system > > https://invent.kde.org/system/kio-admin Can you please have a look at the MR I created? Cheers, Albert >

Re: ghostwriter is ready for your review

2022-10-17 Thread Ingo Klöcker
On Sonntag, 16. Oktober 2022 05:05:40 CEST Megan wrote: > > You have 4 libs in the 3rdparty folder, is there any chance to use actual > > dependencies and not copied code? > > 1. Unfortunately, some of the dependencies aren't in every GNU/Linux > distribution. > 2. It is easier for doing Windows

Re: ghostwriter is ready for your review

2022-10-17 Thread Megan
Hi Albert, If you're going to change something as core to an app as the i18n system I wouldn't say we're done for review stage yet. Or maybe you don't need to change it? Carl said it should be enough to pass review with a Messages.sh and including ECMPoQmTools in the CMakeLists.txt file.  Also,