Re: New repo in kdereview: KWeather

2022-11-09 Thread Devin
> Only nitpick I found as a user was that it's a bit weird that Settings -> > About changes the main window instead of showing about data in the little > settings window. I would suggest making About be one of the buttons on the > main window, or showing the about data in the settings window. I

Re: New repo in kdereview: KWeather

2022-11-09 Thread Jeremy Whiting
After installing kirigami-addons it runs fine, adding my location went smooth, etc. Only nitpick I found as a user was that it's a bit weird that Settings -> About changes the main window instead of showing about data in the little settings window. I would suggest making About be one of the buttons

Re: New repo in kdereview: KWeather

2022-11-09 Thread Devin
Hi Jeremy, Looks like I forgot to add a CMake check for Kirigami Addons. It has been added now. KWeather has a runtime dependency on Kirigami Addons as well, not just Kirigami. Thanks, Devin On Wed, Nov 9, 2022 at 5:31 PM Jeremy Whiting wrote: > > Looks like it's got a runtime dependency on ki

New repo in kdereview: KWeather

2022-11-09 Thread Devin
Hi everyone, I would like to put kweather through kdereview: https://invent.kde.org/plasma-mobile/kweather KWeather is an application that can give simple weather information for different weather locations. Please note that KWeatherCore (the library the app depends on) has already passed kderev

Re: New repo in kdereview: QMLKonsole

2022-11-09 Thread Devin
As an update, at a recent Plasma Mobile meeting we had decided to investigate possibly using Konsole in the future (with mobile adaptations), rather than trying to continue working around qmltermwidget. However, I would still like to get this through review since we do not have any concrete timeli

Re: New repo in kdereview: KRecorder

2022-11-09 Thread Devin
Hi Nate, I've done some work on addressing the feedback: > The app should have a Bugzilla component and its "Report a bug" button should > take users there, as we have been migrating towards for other mobile apps > recently. Resolved > When I open the app for the first time on the desktop, I