Re: KJournald in KDE-Review

2022-11-04 Thread Andreas Cord-Landwehr
Hi Kai, many thanks for this very detailed review! For the nitpicks, I did a first cleanup. Some of the not low hanging fruits regarding UI and features I added to the backlog items in the Invent project. More details below. Cheers, Andreas On Donnerstag, 3. November 2022 14:58:06 CET Kai Uwe

Re: KJournald in KDE-Review

2022-10-30 Thread Andreas Cord-Landwehr
On Sonntag, 23. Oktober 2022 10:34:36 CET Andreas Cord-Landwehr wrote: > Hi, just a short update: Thank you for the comments! Nearly all of them are > already fixed. For a very few I created invent.k.o issues instead, because > they are mostly a maintainability concern and make sen

Re: KJournald in KDE-Review

2022-10-23 Thread Andreas Cord-Landwehr
Hi, just a short update: Thank you for the comments! Nearly all of them are already fixed. For a very few I created invent.k.o issues instead, because they are mostly a maintainability concern and make sense to fix together with planned features (e.g. removal of fixed colors when refactoring

Re: KJournald in KDE-Review

2022-10-12 Thread Andreas Cord-Landwehr
On Mittwoch, 12. Oktober 2022 03:56:03 CEST Aleix Pol wrote: [...] > Then I'd recommend to only make it public API when the time comes. :) > > +1 to making it optional instead, if it makes your life any better. > That said, when we've needed this kind of flexibility in the past, we > have often

Re: KJournald in KDE-Review

2022-10-11 Thread Andreas Cord-Landwehr
On Montag, 10. Oktober 2022 15:34:30 CEST Aleix Pol wrote: > On Sun, Oct 9, 2022 at 7:18 PM Andreas Cord-Landwehr [...] > > Even though KJournald is currently contained in the "libraries" playground > > module, I would like to get it included in the "utilities"

KJournald in KDE-Review

2022-10-09 Thread Andreas Cord-Landwehr
Hi, after a few releases over the past year, I would like to get KJournald included in KDE application releases. This project is about providing both an QItemModel abstraction library for the C-style journald API and providing an efficient graphical browser for journald logs. Sysadmins moved

Re: KDE Frameworks 6 - Virtual Sprint setup

2021-02-02 Thread Andreas Cord-Landwehr
On Sonntag, 31. Januar 2021 16:04:32 CET Christoph Cullmann wrote: > On 2021-01-30 12:14, Volker Krause wrote: > > On Freitag, 29. Januar 2021 15:57:59 CET Adam Szopa wrote: > >> Hello, > >> I've been talking with David Faure about setting up a Sprint focused > >> on KF6 > >> work. Some of the

Re: CI testing with local files

2021-01-28 Thread Andreas Cord-Landwehr
On Donnerstag, 28. Januar 2021 10:20:54 CET Konstantin Kharlamov wrote: > On Wed, 2021-01-27 at 17:36 -0500, Michael Reeves wrote: > > Is there way to reading and writing small files in the CI? I'm in the > > process of writing auto tests for kdiff3. > > Your tests could create a directory inside

Re: Review Request 128749: Backport karchive fix for out of directory files

2016-08-25 Thread Andreas Cord-Landwehr
is that I cannot see the test-tar archive in the diff, but I presume that reviewboard cannot display binary files - Andreas Cord-Landwehr On Aug. 24, 2016, 10:36 nachm., Albert Astals Cid wrote: > > --- > This is an automatically ge

Re: Minuet (music education software) moved to kdereview

2016-01-30 Thread Andreas Cord-Landwehr
On Friday, January 29, 2016 6:53:23 PM CET Sandro Andrade wrote: > Question: Minuet uses TiMidity++ and freepats as run-time > dependencies. Should I improve CMakeLists.txt to detect such > installations (they aren't libraries, maybe some ugly check is > required) as a way to hint packagers to add

Re: Re: Minuet (music education software) moved to kdereview

2016-01-26 Thread Andreas Cord-Landwehr
On Monday 25 January 2016 21:48:27 Albert Astals Cid wrote: > El Sunday 24 January 2016, a les 16:50:18, Andreas Cord-Landwehr va escriure: > > * it looks strange to me that in minuet/cmake/ there are Config-files for > > the 3rd-party library drumstick. My understanding was t

Re: Minuet (music education software) moved to kdereview

2016-01-24 Thread Andreas Cord-Landwehr
Hi Sandro, it is always great when such a cool application lands in KDE Edu. I just made a first and rough (since I do not have all dependencies yet to really compile and test it) code review. Here a some minors I noticed: * the application does not link against KCrash (which is needed for

Re: Minuet (music education software) moved to kdereview

2016-01-24 Thread Andreas Cord-Landwehr
On Sunday, January 24, 2016 6:47:17 PM CET Elvis Angelaccio wrote: > 2016-01-24 16:50 GMT+01:00 Andreas Cord-Landwehr <cordlandw...@kde.org>: > > also in the main.cpp there should be a call to "KCrash::initialize();" > > Shouldn't this happen automatically? > Th

Re: Re: Re: KDE Applications Versioning

2015-07-21 Thread Andreas Cord-Landwehr
On Tuesday 14 July 2015 07:08:57 Andreas Cord-Landwehr wrote: If it is OK this way, I can add it later today to the wiki page. Hi, since I did not hear any oppositions, I just added the paragraph to the wiki page draft. Cheers, Andreas

Re: Re: KDE Applications Versioning

2015-07-14 Thread Andreas Cord-Landwehr
On Monday 13 July 2015 23:14:17 Albert Astals Cid wrote: I did a few tweaks, i still feel it seems this is the official way other than an optional way of defining the version but maybe that's just me. Hi, I have the same feeling as Albert that the current text is not clear enough that both

Re: Scripting/Extensions BoF at Akademy?

2014-08-12 Thread Andreas Cord-Landwehr
Nice idea to do a BoF about this topic! Since we use a lot of QtScript in Rocs for scripting (and I really would like to also offer Python support), I am also quite interested. Do you want to suggest a time slot for the BoF? cheers, Andreas

Re: KDE Review - Moving Artikulate to KDE Edu

2014-02-09 Thread Andreas Cord-Landwehr
On Sunday 26 January 2014 16:39:08 Albert Astals Cid wrote: El Dimarts, 14 de gener de 2014, a les 19:52:57, Albert Astals Cid va So I did have a look at Artikulate yesterday and just found some minor nagging user flow issues that I told Andreas and he says he would be fixing. Yeah, all fixed

Re: Re: kqmlgraphplugin -- a QML plugin to render beautiful and interactive graphs

2014-02-03 Thread Andreas Cord-Landwehr
On Tuesday 28 January 2014 23:26:58 Albert Astals Cid wrote: I think the code is pretty stable. It's used inside KTouch without any problems since KDE 4.10. I'm less sure about how the release should be done and there these components fits in. Should this plugin be distributed on its

Re: KDE Review - Moving Artikulate to KDE Edu

2014-01-27 Thread Andreas Cord-Landwehr
On Sunday 26 January 2014 17:24:11 Albert Astals Cid wrote: Other than that, looks good to me to move to kdeedu *but* we need to decide what to do with kqmlgraphplugin first, since we can't have a kdeedu app depending on a playground lib. Are there technical reasons why we cannot?

Re: Re: KDE Review - Moving Artikulate to KDE Edu

2014-01-14 Thread Andreas Cord-Landwehr
Hi, I think you should work on getting kqmlgraphplugin released first, depending on something unreleased scares me a bit. Just talked to Sebastian (maintainer of the plugin) and he will do a technical preview release of the plugin soon. BTW this code already exists in KTouch for quite some

KDE Review - Moving Artikulate to KDE Edu

2014-01-13 Thread Andreas Cord-Landwehr
Hey all, after about one year of development and two technical preview releases, we thought that is time to move Artikulate to KDE Review, with the goal to land eventually in the KDE Educational module. (a heads-up mail about this proposal also goes to the KDE-Edu list) The repository for