t;Hide" don't seem to work anyway and the others were
not tested.
Thanks,
Daniel Faust
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126851/#review91476
-------
On Jan. 23, 2016, 2:14 p.m., Daniel Faust wrote:
>
> ---
" and "Teardown
Device" operations of the service.
The operations "Show" and "Hide" don't seem to work anyway and the others were
not tested.
Thanks,
Daniel Faust
marked as submitted.
Review request for kde-workspace and Plasma.
Changes
---
Submitted with commit 8bedfde2894a60dc72a0bd40589dfb900776dace by Daniel Faust
to branch master.
Repository: plasma-workspace
Description
---
I wrote a qml applet using the places data engine and noticed
displaying different combinations of "seconds", "date" and "timezone"
works.
Thanks,
Daniel Faust
available.
Diffs
-
src/plasma/contents/ui/main.qml a847f45
Diff: https://git.reviewboard.kde.org/r/127104/diff/
Testing
---
Thanks,
Daniel Faust
test and maximumCharacterWidth returned about twice the width
actually needed.
- Daniel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127102/#review92514
---------
ontMetric's maximumCharacterWidth
> >
> > * numChars.
> >
> > Then we could kill sizeHelper competely (FontMetric's didn't exist when
> > this was written)
>
> Marco Martin wrote:
> hoping maximumCharacterWidth is reliable fo
ontMetric's maximumCharacterWidth
> >
> > * numChars.
> >
> > Then we could kill sizeHelper competely (FontMetric's didn't exist when
> > this was written)
>
> Marco Martin wrote:
> hoping maximumCharacterWidth is reliable fo
ontMetric's maximumCharacterWidth
> >
> > * numChars.
> >
> > Then we could kill sizeHelper competely (FontMetric's didn't exist when
> > this was written)
>
> Marco Martin wrote:
> hoping maximumCharacterWidth is reliable fo
ontMetric's maximumCharacterWidth
> >
> > * numChars.
> >
> > Then we could kill sizeHelper competely (FontMetric's didn't exist when
> > this was written)
>
> Marco Martin wrote:
> hoping maximumCharacterWidth is reliable fo
: https://git.reviewboard.kde.org/r/127102/diff/
Testing
---
Works with horizontal and vertical panel.
Also displaying different combinations of "seconds", "date" and "timezone"
works.
Thanks,
Daniel Faust
ontMetric's maximumCharacterWidth
> >
> > * numChars.
> >
> > Then we could kill sizeHelper competely (FontMetric's didn't exist when
> > this was written)
>
> Marco Martin wrote:
> hoping maximumCharacterWidth is reliable fo
)
-
applets/digital-clock/package/contents/ui/DigitalClock.qml 95bb071
Diff: https://git.reviewboard.kde.org/r/127102/diff/
Testing
---
Works with horizontal and vertical panel.
Also displaying different combinations of "seconds", "date" and "timezone"
works.
Thanks,
Daniel Faust
thing.
- Daniel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127102/#review93561
---
On März 8, 2016, 6:53 nachm., Daniel F
> On März 16, 2016, 6:19 nachm., Martin Klapetek wrote:
> > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 400
> > <https://git.reviewboard.kde.org/r/127393/diff/1/?file=453347#file453347line400>
> >
> > Have you tried dateLabelLeft.paint
iff: https://git.reviewboard.kde.org/r/127393/diff/
Testing
---
Thanks,
Daniel Faust
-
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127393/#review93620
-------
On März 16, 2016, 4:53 nachm., Daniel Faust wrote:
>
> --
> On März 16, 2016, 6:19 nachm., Martin Klapetek wrote:
> > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 400
> > <https://git.reviewboard.kde.org/r/127393/diff/1/?file=453347#file453347line400>
> >
> > Have you tried dateLabelLeft.paint
s (updated)
-
applets/digital-clock/package/contents/ui/DigitalClock.qml 02d55a9
Diff: https://git.reviewboard.kde.org/r/127393/diff/
Testing
---
Thanks,
Daniel Faust
print an error that you can't and one is
> > ignored
> >
> > Also leave this in the font { } format please
>
> Daniel Faust wrote:
> Yes, I copy'n'pasted it. How about I throw in an additional commit to fix
> it everywhere in the file?
quot;A" and "P" width's and use that? Would spare
> > creating two Date objects and two calls to Qt.formatTime
>
> Daniel Faust wrote:
> No, because eg. in german the strings for am and pm are "vorm." and
> "nachm.".
>
> Martin K
nd use that as a scaling factor.
- Daniel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127393/#review93609
-------
On Mär
0001-Use-fixed-width-for-digital-clock-applet.patch
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/16/81b4a902-1454-4155-9fda-552b8acba1a8__0001-Use-fixed-width-for-digital-clock-applet.patch
Thanks,
Daniel Faust
marked as submitted.
Review request for kde-workspace and Plasma.
Changes
---
Submitted with commit e7f09ba1eb976c4f282145016d34fe87de515a25 by Daniel Faust
to branch master.
Bugs: 347724
https://bugs.kde.org/show_bug.cgi?id=347724
Repository: plasma-workspace
Description
, visit:
https://git.reviewboard.kde.org/r/127393/#review93821
---
On März 19, 2016, 2:16 nachm., Daniel Faust wrote:
>
> ---
> This is an automatically generated e-mail. T
> On März 21, 2016, 4:08 nachm., Martin Klapetek wrote:
> > Thanks!
>
> Daniel Faust wrote:
> I already started to rewrite the clock applet. I got pretty far actually,
> and this issue arose again.
> I think it was always intended to use the default font size
separator height to 70% of the applet height.
Diffs
-
applets/digital-clock/package/contents/ui/DigitalClock.qml 02d55a9
Diff: https://git.reviewboard.kde.org/r/127393/diff/
Testing
---
Thanks,
Daniel Faust
28 matches
Mail list logo
