Re: Review Request 113360: PolkitActionsKCM: Use a simple pointer for m_actionWidget.

2013-12-09 Thread Dario Freddi
- it's probably clearer if we put new PolkitKde::ActionWidget(this) as an initializer for m_actionWidget in the constructor. - Dario Freddi On Dec. 8, 2013, 10:45 a.m., Ivan Shapovalov wrote: --- This is an automatically generated e-mail

Re: Review Request 110102: Change 2 strings from Display to Screen for better consistency.

2013-04-20 Thread Dario Freddi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110102/#review31334 --- Ship it! Ship It! - Dario Freddi On April 20, 2013, 2:24

Re: Review Request 109792: Update 'dim display' algorithm.

2013-04-02 Thread Dario Freddi
trip to the dentist last days. Allow me some hours/days to wash away the pain, and I'll be on this. - Dario Freddi On April 2, 2013, 1:52 p.m., Danny Baumann wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 109133: Allow async KAuth Action with helper (and disallow async without helper)

2013-02-26 Thread Dario Freddi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109133/#review28104 --- Ship it! Ship It! - Dario Freddi On Feb. 25, 2013, 11:25

Re: Review Request 108418: use system to suspend and hibernate in powerdevil

2013-01-14 Thread Dario Freddi
a look at this as well, but ideally you should probably talk to Lukas about it. - Dario Freddi On Jan. 15, 2013, midnight, Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: fix for some typos

2012-06-26 Thread Dario Freddi
On June 16, 2012, 4:15 p.m., Lamarque Vieira Souza wrote: kdeui/actions/kaction.cpp, line 408 http://git.reviewboard.kde.org/r/105278/diff/1/?file=68027#file68027line408 Well, commit 3d789c9dcda0179aac40e2bcf58df06cccf84ed5 is the one that commented this line, but Dario did not

Re: GSoC: automatic brightness adjustment

2012-04-08 Thread Dario Freddi
so simple.  More importantly, it requires an additional piece of hardware, which is very inconvenient and cumbersome. On Thu, Apr 5, 2012 at 2:24 PM, Simon Oosthoek soml...@xs4all.nl wrote: On 05/04/12 16:39, Dario Freddi wrote: Any other engineers want to give out their opinion? :D

Re: GSoC: automatic brightness adjustment

2012-04-05 Thread Dario Freddi
Il 05 aprile 2012 07:32, Mike Dean miketd...@gmail.com ha scritto: As an electrical engineer, I find this idea sound. Allow me, as an information engineer and a computer scientist, to think you missed part of the picture :) I don't want to challenge your argument of the power consumption of the

Re: GSoC: automatic brightness adjustment

2012-04-05 Thread Dario Freddi
Il 05 aprile 2012 16:28, Christopher Blauvelt cblauv...@gmail.com ha scritto: On Thu, Apr 5, 2012 at 7:20 AM, Dario Freddi drf54...@gmail.com wrote: Il 05 aprile 2012 07:32, Mike Dean miketd...@gmail.com ha scritto: As an electrical engineer, I find this idea sound. Allow me

Re: GSoC: automatic brightness adjustment

2012-04-04 Thread Dario Freddi
Hi, Il 04 aprile 2012 03:12, Vadim Dombrowski pftb...@gmail.com ha scritto:  Hi! I'm a student of Belarusian State University and I would like to participate in GSoC 2012. The idea for my project is to create an automatic brightness adjustment mechanism using web-camera as light sensor.

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-04-01 Thread Dario Freddi
Il 31 marzo 2012 21:03, Stephen Kelly steve...@gmail.com ha scritto: Now I'm confused. Stephen Kelly wrote:     It was rebased onto some relatively recent commit, but not the tip of     the branch. You disagreed with what I said:  - Given that the branch was rebased on top of the last

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-04-01 Thread Dario Freddi
Il 01 aprile 2012 14:35, Stephen Kelly steve...@gmail.com ha scritto: Dario Freddi wrote: gitk indeed has a screwy visualization in there. You conclusion that the tool is screwy is interesting for a few reasons. Maybe some day you'll reconsider it. Wait - I was considering just this specific

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-31 Thread Dario Freddi
On March 30, 2012, 1:14 p.m., Dario Freddi wrote: April is upon us. If no objections arise in the time being, these changes will be merged on Sunday, after which I'll ask Kevin to move KAuth back to tier2/ for prime time. Stephen Kelly wrote: Thanks for making this happen

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-31 Thread Dario Freddi
On March 30, 2012, 1:14 p.m., Dario Freddi wrote: April is upon us. If no objections arise in the time being, these changes will be merged on Sunday, after which I'll ask Kevin to move KAuth back to tier2/ for prime time. Stephen Kelly wrote: Thanks for making this happen

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-31 Thread Dario Freddi
On March 30, 2012, 1:14 p.m., Dario Freddi wrote: April is upon us. If no objections arise in the time being, these changes will be merged on Sunday, after which I'll ask Kevin to move KAuth back to tier2/ for prime time. Stephen Kelly wrote: Thanks for making this happen

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-30 Thread Dario Freddi
, these changes will be merged on Sunday, after which I'll ask Kevin to move KAuth back to tier2/ for prime time. - Dario Freddi On March 18, 2012, 10:25 p.m., Dario Freddi wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-30 Thread Dario Freddi
On March 30, 2012, 1:14 p.m., Dario Freddi wrote: April is upon us. If no objections arise in the time being, these changes will be merged on Sunday, after which I'll ask Kevin to move KAuth back to tier2/ for prime time. Stephen Kelly wrote: Thanks for making this happen

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-22 Thread Dario Freddi
On March 18, 2012, 11:04 p.m., Stephen Kelly wrote: Nice, thanks and sorry for the noise, and thanks for making the branch. Dario Freddi wrote: Np, hope you'll be able to have a quick look at it as well, it would be great :) Stephen Kelly wrote: Mostly it looks fine

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-21 Thread Dario Freddi
-mail. To reply, visit: http://git.reviewboard.kde.org/r/104337/#review11717 --- On March 18, 2012, 10:25 p.m., Dario Freddi wrote: --- This is an automatically generated e-mail

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-20 Thread Dario Freddi
On March 18, 2012, 11:04 p.m., Stephen Kelly wrote: Nice, thanks and sorry for the noise, and thanks for making the branch. Dario Freddi wrote: Np, hope you'll be able to have a quick look at it as well, it would be great :) Stephen Kelly wrote: Mostly it looks fine

Review Request: Make KAuth ready for frameworks + API Changes

2012-03-18 Thread Dario Freddi
/kauthexecutejob.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/104337/diff/ Testing --- New unit tests pass 100% Thanks, Dario Freddi

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-18 Thread Dario Freddi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104337/#review11594 --- On March 18, 2012, 10:25 p.m., Dario Freddi wrote

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-18 Thread Dario Freddi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104337/#review11596 --- On March 18, 2012, 10:25 p.m., Dario Freddi wrote: --- This is an automatically

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-18 Thread Dario Freddi
. To reply, visit: http://git.reviewboard.kde.org/r/104337/#review11598 --- On March 18, 2012, 10:25 p.m., Dario Freddi wrote: --- This is an automatically generated e-mail. To reply

Re: Please avoid noisy merge commits in frameworks

2012-02-19 Thread Dario Freddi
2012/2/19 Stephen Kelly steve...@gmail.com: Stephen Kelly wrote: Hi there, I was reviewing the changes in the frameworks branch from yesterday. Something I noticed was that there are a lot of merge commits that don't need to exist. Ugh. Yet more of this just appeared... Recent history in

Re: Please avoid noisy merge commits in frameworks

2012-02-19 Thread Dario Freddi
2012/2/19 Ben Cooksley bcooks...@kde.org: First, our hooks are in python - so any changes would need to be in Python as well. I can speak a bit of python, would be a nice way for learning more :) Second, there is a legitimate use for pushing merge commits - namely integrating a seperate

Forward porting policy

2012-01-20 Thread Dario Freddi
Howdy, I just pushed a fix to KDE/4.8 in workspace. Now, when trying to forward-port as usual, a variety of commits by scripty, and a commit from a fellow developer, were merged as well. Which raises two questions that boggle me since a while: 1. Should 4.x always be fully merged into master?

Re: hard-dep for Qt 4.8

2012-01-18 Thread Dario Freddi
2012/1/18 Thomas Zander zan...@kde.org: On Wednesday 18 January 2012 06.35.57 Martin Gräßlin wrote: I didn't say that this is a reason. I wanted to highlight the problem of not  depending on 4.8 and everybody using 4.8. I'm not going to start reviewing code for is this a Qt 4.8 change.

Re: hard-dep for Qt 4.8

2012-01-18 Thread Dario Freddi
2012/1/18 Thomas Zander zan...@kde.org: On Wednesday 18 January 2012 09.05.32 Dario Freddi wrote: if you remember there are a lot of people using KDE that are not 'core' developers. Typically they are one-time developers, they are artists, they are translators etc [] That said, I am

Re: Proposal: have Solid::beginSuppressingScreenPowerManagement inhibit screensaver as well

2012-01-17 Thread Dario Freddi
Cool :) If no objections arise within the next hours, I'll commit the change 2012/1/17 Alex Fiestas afies...@kde.org: On 01/17/2012 05:17 AM, Dario Freddi wrote: Howdy, this mail comes after a certain discussion on how to handle screen inhibition. At the moment, the aforementioned function

Proposal: have Solid::beginSuppressingScreenPowerManagement inhibit screensaver as well

2012-01-16 Thread Dario Freddi
Howdy, this mail comes after a certain discussion on how to handle screen inhibition. At the moment, the aforementioned function leads to an inhibition of DPMS features and brightness handling - I propose to change that to include also Screensaver inhibition, to provide a full hassle-free

Re: libmm-qt and libnm-qt still in KDE Review

2012-01-05 Thread Dario Freddi
Go for it! 2012/1/5 Lamarque V. Souza lamar...@kde.org: Em Wednesday 04 January 2012, Ben Cooksley escreveu: Hi all, Just doing a little spring cleaning of KDE Review and I noticed that libmm-qt and libnm-qt are still there. What was the final decision on where they are going to be

Re: adding a runtime dependency into KDELIBS

2011-11-24 Thread Dario Freddi
(sorry Aaron for the duplicate, blame GMail) 2011/11/24 Aaron J. Seigo ase...@kde.org: On Thursday, November 24, 2011 01:21:12 Dario Freddi wrote: These capabilities used to be provided by HAL in the 10-usb-music-players.fdi file, but HAL is now deprecated, so the information is being

Re: adding a runtime dependency into KDELIBS

2011-11-24 Thread Dario Freddi
Ship it! 2011/11/24 Alex Fiestas afies...@kde.org: So, do have I have green light to give the ship it to this patch? Thanks and sorry for the mess of me not explaining :p

Re: adding a runtime dependency into KDELIBS

2011-11-23 Thread Dario Freddi
2011/11/24 Albert Astals Cid aa...@kde.org: El Dimecres, 23 de novembre de 2011, a les 00:00:29, Alex Fiestas va escriure: We're in the process of merging a review which will partly fix the sad situation of MTP/MPI/iPod devices in libsolid, the review I'm talking about is:

Re: adding a runtime dependency into KDELIBS

2011-11-23 Thread Dario Freddi
2011/11/24 Dario Freddi drf54...@gmail.com: 2011/11/24 Albert Astals Cid aa...@kde.org: El Dimecres, 23 de novembre de 2011, a les 00:00:29, Alex Fiestas va escriure: We're in the process of merging a review which will partly fix the sad situation of MTP/MPI/iPod devices in libsolid

Re: Frameworks mailing list

2011-11-22 Thread Dario Freddi
Hello, 2011/11/16 Albert Astals Cid aa...@kde.org: In case someone is interested since it has never mentioned in this list, there is a frameworks mailing list at kde-frameworks-devel https://mail.kde.org/mailman/listinfo/kde-frameworks-devel I won't comment on having a separate list or

Re: Re: Re: Security Audit Request for Screenlocker Branch

2011-10-12 Thread Dario Freddi
2011/10/12 Martin Gräßlin mgraess...@kde.org: On Wednesday 12 October 2011 09:10:40 Oswald Buddenhagen wrote: Of course KWin is a more complex application than others, but given what we need in a screen locker the difference becomes marginal IMHO. yes. one should consider decoupling the

Re: The future of Power Management - together with Activities

2011-10-03 Thread Dario Freddi
On Monday 03 October 2011 06:38:29 Scott Kitterman wrote: On Sunday, October 02, 2011 06:44:41 PM Dario Freddi wrote: I would like to draw your attention to the address of this list. It has a nice -devel prefix. I don´t take part in discussions where I am not knowledgeable about the topic

Re: The future of Power Management - together with Activities

2011-10-03 Thread Dario Freddi
-- --- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B signature.asc Description: This is a digitally signed message part.

Re: The future of Power Management - together with Activities

2011-10-03 Thread Dario Freddi
showcasing the new config UI will appear soon as well. Alex -- --- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B signature.asc Description: This is a digitally signed message part.

Re: The future of Power Management - together with Activities

2011-10-02 Thread Dario Freddi
resorting to activities at all -Todd -- --- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B signature.asc Description: This is a digitally signed message part.

Re: The future of Power Management - together with Activities

2011-10-02 Thread Dario Freddi
On Sunday 02 October 2011 15:04:35 Alberto Villa wrote: can you please just leave a notification for this? even if it doesn't trigger a profile change, it's very useful to know that the battery is going to die soon Makes sense indeed -- --- Dario Freddi KDE Developer GPG Key

Re: The future of Power Management - together with Activities

2011-10-02 Thread Dario Freddi
On Sunday 02 October 2011 16:26:16 Markus Slopianka wrote: On Samstag 01 Oktober 2011 16:27:48 Dario Freddi wrote: We focused on simplicity, still without losing power-user features Quite frankly: What you describe sounds way more complicated. Don't see any simplicity in your proposal

Re: The future of Power Management - together with Activities

2011-10-02 Thread Dario Freddi
it and creating a new profile and configure it, if that's the sole purpose of the change? -- --- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B signature.asc Description: This is a digitally signed message part.

Re: The future of Power Management - together with Activities

2011-10-02 Thread Dario Freddi
On Sunday 02 October 2011 20:03:47 Stefan Majewsky wrote: On Sun, Oct 2, 2011 at 7:58 PM, Dario Freddi drf54...@gmail.com wrote: I still haven't found a you're right after a thousand times I've been explaining the only real saver you can configure is brightness, and this kinda concerns me

Re: The future of Power Management - together with Activities

2011-10-02 Thread Dario Freddi
___ Plasma-devel mailing list plasma-de...@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- --- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B signature.asc Description: This is a digitally signed message part.

Re: The future of Power Management - together with Activities

2011-10-02 Thread Dario Freddi
this bit, it will never be enough. -- --- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B signature.asc Description: This is a digitally signed message part.

Re: The future of Power Management - together with Activities

2011-10-02 Thread Dario Freddi
plasma-de...@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- --- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B signature.asc Description: This is a digitally signed message part.

Re: The future of Power Management - together with Activities

2011-10-02 Thread Dario Freddi
2011/10/2 Scott Kitterman k...@kitterman.com: On Sunday, October 02, 2011 08:37:58 PM Dario Freddi wrote: On Sunday 02 October 2011 20:31:37 Martin Gräßlin wrote: And that's now exactly the point: if you don't have any clue about what is happening your I want to save power and  not let

Re: The future of Power Management - together with Activities

2011-10-02 Thread Dario Freddi
2011/10/2 Scott Kitterman k...@kitterman.com: On Sunday, October 02, 2011 09:28:42 PM Dario Freddi wrote: No, sorry to say that again. There are two categories of people: those who know what they are talking about and those who don't. Your understanding of this categorization is coming from

Re: The future of Power Management - together with Activities

2011-10-02 Thread Dario Freddi
2011/10/2 todd rme toddrme2...@gmail.com: On Sun, Oct 2, 2011 at 9:28 PM, Dario Freddi drf54...@gmail.com wrote: On Sunday 02 October 2011 21:03:45 todd rme wrote: Thinking over the conversation a bit, I think the disagreement stems not from the activities vs. profiles issue, but rather

Re: The future of Power Management - together with Activities

2011-10-02 Thread Dario Freddi
2011/10/2 David Jarvie djar...@kde.org: On Sunday 02 October 2011 18:47:19 Dario Freddi wrote: On Sunday 02 October 2011 19:34:42 Andreas Pakulat wrote: That leaves out the use-case of not wanting to inhibit all aspects of the current power-save mode, but only a part by switching

Re: The future of Power Management - together with Activities

2011-10-02 Thread Dario Freddi
Btw, I would like to leave the readers, mainly the two who are accusing me of being a d**k, an exercise and count how many times the following questions came up: -Ok but I cannot watch my videos anymore -I will not be able to configure my profiles anymore -Blahblah I want to do power

Re: The future of Power Management - together with Activities

2011-10-02 Thread Dario Freddi
this helps in clearing some misunderstandings. P.S.: As you can see, there is NOTHING about activities in this video, I don´t even have implemented that part, which is completely independent anyway. 2011/10/2 Dario Freddi drf54...@gmail.com: Btw, I would like to leave the readers, mainly the two

The future of Power Management - together with Activities

2011-10-01 Thread Dario Freddi
activities even more useful. Do you like it? More suggestions? Speak now or shut up forever! -- --- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B signature.asc Description: This is a digitally signed message part.

Re: The future of Power Management - together with Activities

2011-10-01 Thread Dario Freddi
On Saturday 01 October 2011 16:55:54 Marco Martin wrote: On Saturday 01 October 2011, Dario Freddi wrote: Hello all, and sorry for cross-posting. At the same time, the combobox for selecting a profile in the battery applet will be removed. It will, although, be replaced by a toggle button

Re: The future of Power Management - together with Activities

2011-10-01 Thread Dario Freddi
the same way. If you were doing such a thing, depending on why you were switching, you might need to create a new activity. Greetings Stefan -- --- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B signature.asc Description: This is a digitally signed message part.

Re: The future of Power Management - together with Activities

2011-10-01 Thread Dario Freddi
-- --- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B signature.asc Description: This is a digitally signed message part.

Re: The future of Power Management - together with Activities

2011-10-01 Thread Dario Freddi
On Saturday 01 October 2011 21:21:40 Andras Mantia wrote: [Please reply on both lists if you cross-posted, otherwise dicussion will be more fragmented. I just looked up the plasma list out of curiosity, normally I don't follow, so your mail would have been missed.] Dario Freddi wrote: I

Re: The future of Power Management - together with Activities

2011-10-01 Thread Dario Freddi
at a very bad time and there is no way to prevent them. That's indeed to be fixed inside those daemons - if we were to start thinking like this, KDE would be the land of workarounds. Cheers, Lukas -- --- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B signature.asc

Re: The future of Power Management - together with Activities

2011-10-01 Thread Dario Freddi
, except for a small change in the UI. -- --- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B signature.asc Description: This is a digitally signed message part.

Re: The future of Power Management - together with Activities

2011-10-01 Thread Dario Freddi
On Saturday 01 October 2011 23:33:22 Scott Kitterman wrote: On Saturday, October 01, 2011 11:21:46 PM Dario Freddi wrote: On Saturday 01 October 2011 23:09:27 Scott Kitterman wrote: I don't understand how creating a new activity represents an improvement to the user. If I understand

Re: The future of Power Management - together with Activities

2011-10-01 Thread Dario Freddi
me that activities can also be used to save power, as you can pause apps/plasmoids (which are the real resource- hungry things). This is a nice side effect and another good reason towards using this approach. -- --- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B

Re: Where does KAuth belong?

2011-09-17 Thread Dario Freddi
that automatically. This is also part of what makes an application a KDE application. We shouldn't expect from all our developers that they suddenly take care of all that themselves. Alex -- --- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B signature.asc

Re: Enviroment variables and KAuth

2011-07-22 Thread Dario Freddi
2011/7/5 Konstantinos Smanis konstantinos.sma...@gmail.com Is it a bug or feature that no enviroment variables (most notably $PATH) are set for DBus-activated KAuth helpers? Manually launching the helper from a shell doesn't lead to this behaviour: enviroment variables are properly set.