Re: Review Request 113885: 3 types of blur

2013-11-20 Thread Fredrik Höglund
://git.reviewboard.kde.org/r/113885/#comment31577 An unfortunate side effect of this is that this API becomes incompatible with the equivalent API on Windows. - Fredrik Höglund On Nov. 15, 2013, 2:54 p.m., Marco Martin wrote

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Fredrik Höglund
to KSplashX? Let's not forget that the reason KPlash was rewritten to only depend on X + libjpeg + libpng was so that the startup time would be limited by the time it takes to load the images for the theme. - Fredrik Höglund On Oct. 24, 2013, 2:19 p.m., Martin Klapetek wrote

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Fredrik Höglund
On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: What's the cold startup time like for KSplashQML compared to KSplashX? Let's not forget that the reason KPlash was rewritten to only depend on X + libjpeg + libpng was so that the startup time would be limited by the time it takes

Re: Review Request 110649: add kimgio WebP image format plugin

2013-06-16 Thread Fredrik Höglund
should look into using lossless WebP for images in KDE, since WebP has faster decompression than libpng, and produces smaller files. I've done some tests with Oxygen icons that confirms this. - Fredrik Höglund On June 16, 2013, 11:58 a.m., Martin Koller wrote

Re: Review Request 110649: add kimgio WebP image format plugin

2013-05-26 Thread Fredrik Höglund
/#comment24527 This is not particularly efficient. WebPDecodeBGRAInto() can decode directly into a QImage without using an intermediate buffer. - Fredrik Höglund On May 26, 2013, 12:20 p.m., Martin Koller wrote

Re: Review Request 110339: Drop cursor font support and convert KDE Classic into an image-based theme

2013-05-06 Thread Fredrik Höglund
://git.reviewboard.kde.org/r/110339/#comment23953 This will probably segfault if images is null. kcontrol/input/xcursor/xcursortheme.cpp http://git.reviewboard.kde.org/r/110339/#comment23954 Same issue here. - Fredrik Höglund On May 6, 2013, 8:55 p.m., Eike Hein wrote

Re: Review Request 110339: Drop cursor font support and convert KDE Classic into an image-based theme

2013-05-06 Thread Fredrik Höglund
LGTM. - Fredrik Höglund On May 6, 2013, 11:04 p.m., Eike Hein wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110339

Re: plasma and new shadow mess

2013-01-07 Thread Fredrik Höglund
On Monday 07 January 2013, Martin Gräßlin wrote: handing over the pixmap id intenrally to the shadow system is exactly what we do in plasma. granted, it is outside of kwin and we're doing this with an xatom ... but this is precisely how plasma is doing it now: we rely on kwin (or another

Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

2013-01-05 Thread Fredrik Höglund
that the event should be delivered to winId(). KSelectionOwner does not send XFixes events; they are generated by the X server. - Fredrik Höglund On Jan. 5, 2013, 2:38 p.m., Thomas Lübking wrote: --- This is an automatically generated e

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-05 Thread Fredrik Höglund
On Jan. 5, 2013, 3:13 p.m., Fredrik Höglund wrote: Because the XFixesSelectSelectionInput() call specifies that the event should be delivered to winId(). KSelectionOwner does not send XFixes events; they are generated by the X server. Thomas Lübking wrote: Ok, problem

Re: Review Request: Make mouse cursor size configurable

2011-07-20 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/#review4898 --- Lucas, first of all I want to say thank you for working on

Re: Git Worflow, branch creation.

2011-05-17 Thread Fredrik Höglund
On Tuesday 17 May 2011, Ivan Cukic wrote: On Tuesday, 17. May 2011. 11.42.41 Maksim Orlovich wrote: Testing. If everyone is working on branches on cool new stuff, the release will be crap. I don't agree. Freezes just stop the development - it doesn't improve the bugfixing as much.