marked as submitted.
Review request for Build System, kdelibs and Luigi Toscano.
Changes
---
Submitted with commit 1b0cb8ed48b5bf816cd5fe27d435568e69d94113 by Hrvoje Senjan
to branch KDE/4.14.
Repository: kdelibs
Description
---
Backport of review 116650.
Needed to fix build of
marked as submitted.
Review request for Build System, kdelibs, Localization and Translation (l10n),
Albert Astals Cid, and Alexander Neundorf.
Changes
---
Submitted with commit fd59e696d0a27e28b5551dff3d88d94d16787c2b by Hrvoje Senjan
to branch KDE/4.14.
Repository: kdelibs
Description
tps://git.reviewboard.kde.org/r/125561/#review86609
-------
On Oct. 10, 2015, 1:42 a.m., Hrvoje Senjan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125561/
> ---
-
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125561/#review86622
---
On Oct. 10, 2015, 1:42 a.m., Hrvoje Senjan wrote:
>
> --
e 91e88f7
Diff: https://git.reviewboard.kde.org/r/125561/diff/
Testing
---
Skanlite now builds.
Thanks,
Hrvoje Senjan
call first):
po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES)
```
Diffs
-
cmake/modules/FindGettext.cmake 91e88f7
Diff: https://git.reviewboard.kde.org/r/125561/diff/
Testing
---
Skanlite now builds.
Thanks,
Hrvoje Senjan
s now build.
Thanks,
Hrvoje Senjan
), i would avoid
merging this to kdelibs4, and mail kde-distro-packagers with a link to this
review instead ;-)
- Hrvoje Senjan
On Oct. 5, 2015, 4:21 p.m., Harald Sitter wrote:
>
> ---
> This is an automatically generated e-mail.
SysGuard::Process::command' does not have class type
[ 451s] QString cmdline = proc ? proc->command.simplified() : QString();
// proc->command has a trailing space???
[ 451s]^
- Hrvoje Senjan
On Feb. 20, 2015, 10:46 p.m.,
soversion
- Hrvoje Senjan
On Jan. 13, 2015, 10:08 p.m., Gregor Mi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
tps://git.reviewboard.kde.org/r/120876/
- Hrvoje Senjan
On Oct. 10, 2014, 1:30 a.m., Ian Wadham wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.k
> On Oct. 19, 2014, 2:49 a.m., Hrvoje Senjan wrote:
> > interfaces/kompareinterface.h, line 25
> > <https://git.reviewboard.kde.org/r/120627/diff/6/?file=320653#file320653line25>
> >
> > this include is also provided by KDELibs4Support..
> >
>
tps://git.reviewboard.kde.org/r/120627/#comment47867>
this include is also provided by KDELibs4Support..
quick grep shows it was also left in interfaces/kompareinterfaceexport.h
- Hrvoje Senjan
On Oct. 19, 2014, 12:13 a.m., Jeremy Whiting
> On Sept. 6, 2014, 2:46 p.m., Lukáš Tinkl wrote:
> > [ 22%] Building CXX object src/CMakeFiles/KF5XmlGui.dir/kmainwindow.cpp.o
> >
> >
> > /home/ltinkl/git/plasma-next-
it is. however, with this solution, user will never know (i.e. predict) will
kuiserver, or kuiserver5 be started - unless you also change the name (not
filename) of the service. that will however then need adjusting in 'downstream'
consumers of kuiserver
- Hrvoje Senjan
On March 2
next beta ;-)
(also, it would be nice to have a CMake indication about pam-wallet dependency
- from patch, it looks it's a runtime only dep?)
- Hrvoje Senjan
On March 2, 2014, 11:33 p.m., Àlex Fiestas wrote:
>
> ---
> This is an
s.txt ddf0ae0
kioslave/trash/tests/CMakeLists.txt 651f25d
kioslave/trash/trashthroughanalyzer.cpp df0eb87
Diff: https://git.reviewboard.kde.org/r/115371/diff/
Testing
---
Builds.
Thanks,
Hrvoje Senjan
untime for all uses of strigi.
Nothing else was using it =)
- Hrvoje
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115371/#review48573
----------
slave/trash/tests/CMakeLists.txt 651f25d
kioslave/trash/trashthroughanalyzer.cpp df0eb87
Diff: https://git.reviewboard.kde.org/r/115371/diff/
Testing
---
Builds.
Thanks,
Hrvoje Senjan
> On Jan. 21, 2014, 1:16 p.m., Martin Gräßlin wrote:
> > I guess it's obvious from the matching review request for kgloballacel: I
> > consider copying the files to every user as the wrong solution. In Qt terms
> > I would give it a -2.
>
> Thomas Lübking wrote:
> esp. since that means to
only one kglobalaccel. If its from kde4 or
> kde4
> > shouldn't matter so it HAS to keep dbus compatibility.
>
>
> Hrvoje Senjan wrote:
> This would break KF5 applications also ;-) Interface names in xml files
> are untouched in this review =)
> @Jon
> On Jan. 13, 2014, 6:03 p.m., Martin Gräßlin wrote:
> > Wouldn't that break KDElibs4 applications talking to kglobalacceld from KF5?
>
> Thomas Lübking wrote:
> On Montag, 13. Januar 2014 19:24:12 CEST, Michael Jansen wrote:
> > Yes it would. There can be only one kglobalaccel. If its f
> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote:
> > Hm, on the face of it, this patch doesn't really make sense ... launcher
> > items don't have an associated task, so the function should already return
> > early and the extra condition should be redundant. Unless there's a race
> > condition
> On June 9, 2013, 8:38 a.m., Christophe Giboudeaux wrote:
> > plasma/desktop/applets/kickoff/core/config-kickoff-applets.h.cmake:#cmakedefine
> > HAVE_STRIGIDBUS 1
> >
> > this line is not needed anymore with this change
>
> Simeon Bird wrote:
> Thanks - that file consists only of that li
> On May 13, 2013, 2:23 p.m., Commit Hook wrote:
> > This review has been submitted with commit
> > 56e93089160557805f17863b848ac178bb8975a8 by Maarten De Meyer to branch
> > master.
@Maarten, maybe the part about fixing query URL's could also go to KDE/4.10
branch?
- Hrvoje
-
25 matches
Mail list logo
